Implement fullscreen info bubble on Win and Mac

chrome/browser/ui/browser.cc

Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 9f730f0f051940f5561d785dcd9bc726ea75086e..1ae37d001a4015135c742b5a4cebf4bc401937c7 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -33,6 +33,7 @@
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browser_shutdown.h"
 #include "chrome/browser/character_encoding.h"
+#include "chrome/browser/content_settings/host_content_settings_map.h"
 #include "chrome/browser/custom_handlers/protocol_handler_registry.h"
 #include "chrome/browser/custom_handlers/register_protocol_handler_infobar_delegate.h"
 #include "chrome/browser/debugger/devtools_toggle_action.h"
@@ -753,7 +754,7 @@ TabContents* Browser::OpenApplicationTab(Profile* profile,
   // full screen mode in this case?
   if (launch_type == ExtensionPrefs::LAUNCH_FULLSCREEN &&
       !browser->window()->IsFullscreen())
-    browser->ToggleFullscreenMode();
+    browser->ToggleFullscreenMode(false);
 
   return contents;
 }
@@ -1666,7 +1667,10 @@ void Browser::ConvertPopupToTabbedBrowser() {
   browser->window()->Show();
 }
 
-void Browser::ToggleFullscreenMode() {
+// TODO Change this to an enum.
+void Browser::ToggleFullscreenMode(bool for_tab) {
+  bool entering_fullscreen = !window_->IsFullscreen();
+
 #if !defined(OS_MACOSX)
   // In kiosk mode, we always want to be fullscreen. When the browser first
   // starts we're not yet fullscreen, so let the initial toggle go through.
@@ -1676,7 +1680,14 @@ void Browser::ToggleFullscreenMode() {
 #endif
 
   UserMetrics::RecordAction(UserMetricsAction("ToggleFullscreen"));
-  window_->SetFullscreen(!window_->IsFullscreen());
+  if (for_tab) {
+    const GURL& url = GetSelectedTabContents()->GetURL();
+    bool show_buttons = GetFullscreenSetting(url) == CONTENT_SETTING_ASK;
+    window_->SetFullscreen(entering_fullscreen, url, show_buttons);
+  } else {
+    // TODO Replace with browser-specific fullscreen function.
+    window_->SetFullscreen(entering_fullscreen, GURL(), false);
+  }
 
   // Once the window has become fullscreen it'll call back to
   // WindowFullscreenStateChanged(). We don't do this immediately as
@@ -1698,8 +1709,16 @@ void Browser::NotifyTabOfFullscreenExitIfNecessary() {
 }
 
 #if defined(OS_MACOSX)
-void Browser::TogglePresentationMode() {
-  window_->SetPresentationMode(!window_->InPresentationMode());
+void Browser::TogglePresentationMode(bool for_tab) {
+  bool entering_fullscreen = !window_->InPresentationMode();
+  if (for_tab) {
+    const GURL& url = GetSelectedTabContents()->GetURL();
+    bool show_buttons = GetFullscreenSetting(url) == CONTENT_SETTING_ASK;
+    window_->SetPresentationMode(entering_fullscreen, url, show_buttons);
+  } else {
+    // TODO Replace with browser-specific fullscreen function.
+    window_->SetFullscreen(entering_fullscreen, GURL(), false);

[yzshen1, 2011/10/10 19:09:30]

I am not familiar with Mac implementation, but it seems SetPresentationMode
should be used.

[koz (OOO until 15th September), 2011/10/10 22:49:58]

Done.

+  }
   WindowFullscreenStateChanged();
 }
 #endif
@@ -1708,7 +1727,7 @@ void Browser::TogglePresentationMode() {
 void Browser::Search() {
   // Exit fullscreen to show omnibox.
   if (window_->IsFullscreen()) {
-    ToggleFullscreenMode();
+    ToggleFullscreenMode(false);
     // ToggleFullscreenMode is asynchronous, so we don't have omnibox
     // visible at this point. Wait for next event cycle which toggles
     // the visibility of omnibox before creating new tab.
@@ -2635,9 +2654,9 @@ void Browser::ExecuteCommandWithDisposition(
     case IDC_RESTORE_TAB:           RestoreTab();                     break;
     case IDC_COPY_URL:              WriteCurrentURLToClipboard();     break;
     case IDC_SHOW_AS_TAB:           ConvertPopupToTabbedBrowser();    break;
-    case IDC_FULLSCREEN:            ToggleFullscreenMode();           break;
+    case IDC_FULLSCREEN:            ToggleFullscreenMode(false);      break;
 #if defined(OS_MACOSX)
-    case IDC_PRESENTATION_MODE:     TogglePresentationMode();         break;
+    case IDC_PRESENTATION_MODE:     TogglePresentationMode(false);    break;
 #endif
     case IDC_EXIT:                  Exit();                           break;
     case IDC_TOGGLE_VERTICAL_TABS:  ToggleUseVerticalTabs();          break;
@@ -3809,9 +3828,9 @@ void Browser::ToggleFullscreenModeForTab(TabContents* tab,
 
   if (tab_caused_fullscreen_) {
 #if defined(OS_MACOSX)
-    TogglePresentationMode();
+    TogglePresentationMode(true);
 #else
-    ToggleFullscreenMode();
+    ToggleFullscreenMode(true);
 #endif
   } else if (!enter_fullscreen) {
     // If currently there is a tab in "tab fullscreen" mode and fullscreen was
@@ -3887,7 +3906,7 @@ void Browser::CrashedPlugin(TabContents* tab, const FilePath& plugin_path) {
 
 void Browser::ExitTabbedFullscreenModeIfNecessary() {
   if (tab_caused_fullscreen_)
-    ToggleFullscreenMode();
+    ToggleFullscreenMode(false);
   else
     NotifyTabOfFullscreenExitIfNecessary();
 }
@@ -3897,6 +3916,25 @@ void Browser::UpdatePreferredSize(TabContents* source,
   window_->UpdatePreferredSize(source, pref_size);
 }
 
+void Browser::OnAcceptFullscreenPermission(const GURL& url) {

[yzshen1, 2011/10/10 19:09:30]

On Windows:
After clicking "Allow", restarting browser will cause LOG(DFATAL) in
PrefProvider::CanonicalizeContentSettingsExceptions.

Have you met the same issue?

[koz (OOO until 15th September), 2011/10/10 22:49:58]

No, I can't reproduce this. Can you repro if you delete your user data
directory?

+  HostContentSettingsMap* settings_map = profile()->GetHostContentSettingsMap();
+
+  settings_map->SetContentSetting(
+      ContentSettingsPattern::FromString(url.host()),
+      ContentSettingsPattern::Wildcard(), CONTENT_SETTINGS_TYPE_FULLSCREEN,
+      "", CONTENT_SETTING_ALLOW);
+}
+
+void Browser::OnDenyFullscreenPermission() {
+  ExitTabbedFullscreenModeIfNecessary();
+}
+
+ContentSetting Browser::GetFullscreenSetting(const GURL& url) {
+  HostContentSettingsMap* settings_map = profile()->GetHostContentSettingsMap();
+  return settings_map->GetContentSetting(url, url,
+      CONTENT_SETTINGS_TYPE_FULLSCREEN, "");
+}
+
 ///////////////////////////////////////////////////////////////////////////////
 // Browser, TabContentsWrapperDelegate implementation: