Cancel the pending print preview request when the user request to show the system dialog.

Cancel the pending print preview request when the user request to show the system dialog. 

BUG=none
TEST=print preview works after code changes.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98313

[Lei Zhang, 2011-08-25 17:29:00]

http://codereview.chromium.org/7740025/diff/1/chrome/browser/resources/print_...
File chrome/browser/resources/print_preview/print_preview.js (right):

http://codereview.chromium.org/7740025/diff/1/chrome/browser/resources/print_...
chrome/browser/resources/print_preview/print_preview.js:143: if
(showingSystemDialog)
Do you want to do the same below in launchNativePrintDialog() ?

http://codereview.chromium.org/7740025/diff/1/chrome/browser/ui/webui/print_p...
File chrome/browser/ui/webui/print_preview_ui.h (right):

http://codereview.chromium.org/7740025/diff/1/chrome/browser/ui/webui/print_p...
chrome/browser/ui/webui/print_preview_ui.h:100: void
OnCancelPendingPreviewRequest();
This only cancels 1 pending print preview request. There can be more. This is
fine for now, but you may want to add a TODO to say we should cancel all pending
requests.

[kmadhusu, 2011-08-25 18:28:59]

http://codereview.chromium.org/7740025/diff/1/chrome/browser/resources/print_...
File chrome/browser/resources/print_preview/print_preview.js (right):

http://codereview.chromium.org/7740025/diff/1/chrome/browser/resources/print_...
chrome/browser/resources/print_preview/print_preview.js:143: if
(showingSystemDialog)
On 2011/08/25 17:29:00, Lei Zhang wrote:
> Do you want to do the same below in launchNativePrintDialog() ?

Yes.

http://codereview.chromium.org/7740025/diff/1/chrome/browser/ui/webui/print_p...
File chrome/browser/ui/webui/print_preview_ui.h (right):

http://codereview.chromium.org/7740025/diff/1/chrome/browser/ui/webui/print_p...
chrome/browser/ui/webui/print_preview_ui.h:100: void
OnCancelPendingPreviewRequest();
On 2011/08/25 17:29:00, Lei Zhang wrote:
> This only cancels 1 pending print preview request. There can be more. This is
> fine for now, but you may want to add a TODO to say we should cancel all
pending
> requests.

As we discussed, this will cancel all the pending preview requests.

[Lei Zhang, 2011-08-25 18:36:56]

LGTM