Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 7740022: [cros] Don't display error notification on strange network state transitions. (Closed)

Created:
9 years, 4 months ago by Nikita (slow)
Modified:
9 years, 3 months ago
CC:
chromium-reviews, davemoore+watch_chromium.org
Visibility:
Public.

Description

[cros] Don't display error notification on strange network state transitions. When resuming mobile network goes through these states: Idle-Failure-Association-Configuration-Connected-Online state. Idle-Failure should not generate any error notifications as network is not in connecting state yet because modem has not resumed yet. Only network failures happening when network is in active state (like associatuion, configuration etc.) should be shown. BUG=chromium-os:18749 TEST=Manual. No error notification for mobile network when resuming. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/chromeos/cros/network_library.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nikita (slow)
Jason please take a look. More details and cromo/flimflamd logs in issue comments.
9 years, 4 months ago (2011-08-25 15:21:15 UTC) #1
Nikita (slow)
Dmitry, please take a look. More details and cromo/flimflamd logs in issue comments.
9 years, 4 months ago (2011-08-26 06:44:56 UTC) #2
Dmitry Polukhin
LGTM
9 years, 4 months ago (2011-08-26 06:59:21 UTC) #3
Eric Shienbrood
9 years, 3 months ago (2011-08-29 15:35:38 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698