Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1102)

Issue 7740021: Changed computation of func.caller to skip some built-in functions. (Closed)

Created:
9 years, 4 months ago by Lasse Reichstein
Modified:
9 years, 4 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Changed computation of func.caller to skip some built-in functions. Now skips built-in functions called from other built-in functions, so only the initally called built-in function is exposed. Committed: http://code.google.com/p/v8/source/detail?r=9018

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -30 lines) Patch
M src/accessors.cc View 1 2 chunks +67 lines, -30 lines 0 comments Download
test/mjsunit/function-caller.js View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein
9 years, 4 months ago (2011-08-25 12:27:37 UTC) #1
Lasse Reichstein
9 years, 4 months ago (2011-08-25 13:11:09 UTC) #2
William Hesse
LGTM. http://codereview.chromium.org/7740021/diff/1/src/accessors.cc File src/accessors.cc (right): http://codereview.chromium.org/7740021/diff/1/src/accessors.cc#newcode752 src/accessors.cc:752: potential_caller != NULL && potential_caller->IsBuiltin(); I think this ...
9 years, 4 months ago (2011-08-25 13:29:48 UTC) #3
Lasse Reichstein
9 years, 4 months ago (2011-08-25 13:34:11 UTC) #4
http://codereview.chromium.org/7740021/diff/1/src/accessors.cc
File src/accessors.cc (right):

http://codereview.chromium.org/7740021/diff/1/src/accessors.cc#newcode752
src/accessors.cc:752: potential_caller != NULL && potential_caller->IsBuiltin();
On 2011/08/25 13:29:48, William Hesse wrote:
> I think this is clearer as a while loop, or anything that puts the assignments
> to potential_caller and to caller in the correct order (the body and iteration
> step).

Done.

Powered by Google App Engine
This is Rietveld 408576698