Refactor .gyp files:

Refactor .gyp files:

common.gypi now contains global target defaults and is included by all .gyp files;
standalone.gypi contains definitions for stand-alone v8 builds.
This fixes d8 for the ARM simulator.


TEST=compiles and tests pass on all platforms

Committed: http://code.google.com/p/v8/source/detail?r=9019

[Jakob Kummerow, 2011-08-25 09:36:47]

PTAL.

This looks huge, but the changes are actually purely mechanical:
• move stand-alone build specific stuff from common.gypi to standalone.gypi
• move common definitions from v8.gyp and v8-features.gypi to common.gypi

One line is new: in test-wrapper-gypbuild.py, passing the proper "--arch=" flag
to test.py makes ARM tests run correctly.

[Yang, 2011-08-25 11:24:03]

LGTM with comments.

http://codereview.chromium.org/7740020/diff/1/build/standalone.gypi
File build/standalone.gypi (right):

http://codereview.chromium.org/7740020/diff/1/build/standalone.gypi#newcode58
build/standalone.gypi:58: 'v8_can_use_vfp_instructions%': 'true',
You mentioned something about this...

http://codereview.chromium.org/7740020/diff/1/build/standalone.gypi#newcode82
build/standalone.gypi:82: #'ldflags': [ '-pthread', ],
Remove this line.

http://codereview.chromium.org/7740020/diff/1/samples/samples.gyp
File samples/samples.gyp (right):

http://codereview.chromium.org/7740020/diff/1/samples/samples.gyp#newcode43
samples/samples.gyp:43: ],
Can this be moved into common.gypi? For example under target_defaults. As far as
I can see this is because v8::internal::Thread is implemented with pthread on
Linux/Mac, and is part of v8 itself, not limited to d8 or the samples or
cctests.

http://codereview.chromium.org/7740020/diff/1/src/d8.gyp
File src/d8.gyp (right):

http://codereview.chromium.org/7740020/diff/1/src/d8.gyp#newcode80
src/d8.gyp:80: ],
Ditto.

http://codereview.chromium.org/7740020/diff/1/test/cctest/cctest.gyp
File test/cctest/cctest.gyp (right):

http://codereview.chromium.org/7740020/diff/1/test/cctest/cctest.gyp#newcode143
test/cctest/cctest.gyp:143: ],
Ditto.

http://codereview.chromium.org/7740020/diff/1/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

http://codereview.chromium.org/7740020/diff/1/tools/gyp/v8.gyp#newcode760
tools/gyp/v8.gyp:760: ],
Ditto.

[Jakob Kummerow, 2011-08-25 14:46:08]

Comments addressed, trailing whitespace fixed. Landing.

http://codereview.chromium.org/7740020/diff/1/build/standalone.gypi
File build/standalone.gypi (right):

http://codereview.chromium.org/7740020/diff/1/build/standalone.gypi#newcode58
build/standalone.gypi:58: 'v8_can_use_vfp_instructions%': 'true',
On 2011/08/25 11:24:03, Yang wrote:
> You mentioned something about this...

Done.

http://codereview.chromium.org/7740020/diff/1/build/standalone.gypi#newcode82
build/standalone.gypi:82: #'ldflags': [ '-pthread', ],
On 2011/08/25 11:24:03, Yang wrote:
> Remove this line.

Done - sort of. In reaction to your other comment, I've re-enabled this, and
removed the conditional definition below instead.

http://codereview.chromium.org/7740020/diff/1/samples/samples.gyp
File samples/samples.gyp (right):

http://codereview.chromium.org/7740020/diff/1/samples/samples.gyp#newcode43
samples/samples.gyp:43: ],
On 2011/08/25 11:24:03, Yang wrote:
> Can this be moved into common.gypi? For example under target_defaults. As far
as
> I can see this is because v8::internal::Thread is implemented with pthread on
> Linux/Mac, and is part of v8 itself, not limited to d8 or the samples or
> cctests.

Done.

http://codereview.chromium.org/7740020/diff/1/src/d8.gyp
File src/d8.gyp (right):

http://codereview.chromium.org/7740020/diff/1/src/d8.gyp#newcode80
src/d8.gyp:80: ],
On 2011/08/25 11:24:03, Yang wrote:
> Ditto.

Done.

http://codereview.chromium.org/7740020/diff/1/test/cctest/cctest.gyp
File test/cctest/cctest.gyp (right):

http://codereview.chromium.org/7740020/diff/1/test/cctest/cctest.gyp#newcode143
test/cctest/cctest.gyp:143: ],
On 2011/08/25 11:24:03, Yang wrote:
> Ditto.

Done.

http://codereview.chromium.org/7740020/diff/1/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

http://codereview.chromium.org/7740020/diff/1/tools/gyp/v8.gyp#newcode760
tools/gyp/v8.gyp:760: ],
On 2011/08/25 11:24:03, Yang wrote:
> Ditto.

Done.