Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Issue 7740018: MIPS: Remove gp and sp from callee-saved register list. (Closed)

Created:
9 years, 4 months ago by Paul Lind
Modified:
9 years, 4 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Remove gp and sp from callee-saved register list. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9020

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix reg pop per code review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/mips/code-stubs-mips.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/mips/frames-mips.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paul Lind
9 years, 4 months ago (2011-08-25 05:33:19 UTC) #1
fschneider
http://codereview.chromium.org/7740018/diff/1/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): http://codereview.chromium.org/7740018/diff/1/src/mips/code-stubs-mips.cc#newcode3833 src/mips/code-stubs-mips.cc:3833: __ MultiPop((kCalleeSaved | ra.bit()) & ~sp.bit()); I guess you ...
9 years, 4 months ago (2011-08-25 10:50:51 UTC) #2
Paul Lind
http://codereview.chromium.org/7740018/diff/1/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): http://codereview.chromium.org/7740018/diff/1/src/mips/code-stubs-mips.cc#newcode3833 src/mips/code-stubs-mips.cc:3833: __ MultiPop((kCalleeSaved | ra.bit()) & ~sp.bit()); On 2011/08/25 10:50:51, ...
9 years, 4 months ago (2011-08-25 15:47:50 UTC) #3
fschneider
9 years, 4 months ago (2011-08-26 07:11:09 UTC) #4
LGTM.

I'll land it.

Powered by Google App Engine
This is Rietveld 408576698