Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chrome/browser/resources/print_preview/print_preview.js

Issue 7740005: Print preview not showing if default print is invalid. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Update per code review Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/print_preview.js
diff --git a/chrome/browser/resources/print_preview/print_preview.js b/chrome/browser/resources/print_preview/print_preview.js
index 709922bc42c7161a61e3a825c26788b9dcc31f63..d288c7ad34da1d3c017feaed7befb1fd1ae92d1d 100644
--- a/chrome/browser/resources/print_preview/print_preview.js
+++ b/chrome/browser/resources/print_preview/print_preview.js
@@ -814,6 +814,18 @@ function printPreviewFailed() {
}
/**
+ * Display an error message when encountered invalid printer settings.
+ * Called from PrintPreviewMessageHandler::OnInvalidDefaultPrinter().
+ */
+function invalidPrinterSettings() {
kmadhusu 2011/08/30 02:11:27 Using "isTabHidden" variable, you can merge invali
arthurhsu 2011/08/30 20:43:03 Done.
+ displayErrorMessage(localStrings.getString('invalidPrinterSettings'));
+}
+
+function invalidPrinterSettingsAlert() {
kmadhusu 2011/08/30 02:11:27 This function is not required as per my previous c
arthurhsu 2011/08/30 20:43:03 Done.
+ alert(localStrings.getString('invalidPrinterSettings'));
+}
+
+/**
* Called when the PDF plugin loads its document.
*/
function onPDFLoad() {

Powered by Google App Engine
This is Rietveld 408576698