Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/print_preview/print_preview.js

Issue 7740005: Print preview not showing if default print is invalid. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Update per code review Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/printing/print_preview_message_handler.cc ('K') | « chrome/browser/printing/print_preview_message_handler.cc ('k') | chrome/browser/ui/webui/print_preview_data_source.cc » ('j') | chrome/renderer/mock_printer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/print_preview/print_preview.js
diff --git a/chrome/browser/resources/print_preview/print_preview.js b/chrome/browser/resources/print_preview/print_preview.js
index 0231ace521274cdd26e63edf2e225b88d8fd9595..c6961147a5d4b03eb1ff32f5eb2a97ce1a1c5cac 100644
--- a/chrome/browser/resources/print_preview/print_preview.js
+++ b/chrome/browser/resources/print_preview/print_preview.js
@@ -808,6 +808,14 @@ function printPreviewFailed() {
}
/**
+ * Display an error message when encountered invalid default printer.
kmadhusu 2011/08/26 18:50:40 nit: Update the comment.
arthurhsu 2011/08/29 22:53:16 Done.
+ * Called from PrintPreviewMessageHandler::OnInvalidDefaultPrinter().
+ */
+function invalidPrinterSettings() {
+ displayErrorMessage(localStrings.getString('invalidPrinterSettings'));
+}
+
+/**
* Called when the PDF plugin loads its document.
*/
function onPDFLoad() {
« chrome/browser/printing/print_preview_message_handler.cc ('K') | « chrome/browser/printing/print_preview_message_handler.cc ('k') | chrome/browser/ui/webui/print_preview_data_source.cc » ('j') | chrome/renderer/mock_printer.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698