Print preview not showing if default print is invalid.

chrome/browser/resources/print_preview/print_preview.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // require: cr/ui/print_preview_cloud.js
 
 var localStrings = new LocalStrings();
 
 // If useCloudPrint is true we attempt to connect to cloud print
 // and populate the list of printers with cloud print printers.
@@ skipping 796 matching lines @@
  * Display an error message when print preview fails.
  * Called from PrintPreviewMessageHandler::OnPrintPreviewFailed().
  */
 function printPreviewFailed() {
   displayErrorMessageWithButton(localStrings.getString('previewFailed'),
                                 localStrings.getString('launchNativeDialog'),
                                 launchNativePrintDialog);
 }
 
 /**
+ * Display an error message when encountered invalid printer settings.
+ * Called from PrintPreviewMessageHandler::OnInvalidDefaultPrinter().
+ */
+function invalidPrinterSettings() {

[kmadhusu, 2011/08/30 02:11:27]

Using "isTabHidden" variable, you can merge invalidPrinterSettingsAlert()
function definition with this function. 

if (isTabHidden)
  alert(...);
else
  displayErrorMessage(...);

[arthurhsu, 2011/08/30 20:43:03]

Done.

+  displayErrorMessage(localStrings.getString('invalidPrinterSettings'));
+}
+
+function invalidPrinterSettingsAlert() {

[kmadhusu, 2011/08/30 02:11:27]

This function is not required as per my previous comment.

[arthurhsu, 2011/08/30 20:43:03]

Done.

+  alert(localStrings.getString('invalidPrinterSettings'));
+}
+
+/**
  * Called when the PDF plugin loads its document.
  */
 function onPDFLoad() {
   if (previewModifiable) {
     setPluginPreviewPageCount();
   }
   $('pdf-viewer').fitToHeight();
   cr.dispatchSimpleEvent(document, 'PDFLoaded');
   hideLoadingAnimation();
 }
@@ skipping 159 matching lines @@
 <include src="print_preview_animations.js"/>
 <include src="print_preview_cloud.js"/>
 <include src="print_preview_utils.js"/>
 <include src="print_header.js"/>
 <include src="page_settings.js"/>
 <include src="copies_settings.js"/>
 <include src="header_footer_settings.js"/>
 <include src="layout_settings.js"/>
 <include src="color_settings.js"/>
 <include src="margin_settings.js"/>