Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 7740003: content: Move gtk_expanded_container to ui/base/gtk/. (Closed)

Created:
9 years, 4 months ago by Elliot Glaysher
Modified:
9 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, Avi (use Gerrit), Paweł Hajdan Jr., brettw-cc_chromium.org
Visibility:
Public.

Description

content: Move gtk_expanded_container to ui/base/gtk/. This is used in code that will be moved for use in content_shell. BUG=93804 TEST=none; code move Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98282

Patch Set 1 #

Patch Set 2 : Rebase and retry failing windows compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -446 lines) Patch
M chrome/browser/tab_contents/tab_contents_view_gtk.cc View 2 chunks +1 line, -2 lines 0 comments Download
D chrome/browser/ui/gtk/gtk_expanded_container.h View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/browser/ui/gtk/gtk_expanded_container.cc View 1 chunk +0 lines, -193 lines 0 comments Download
D chrome/browser/ui/gtk/gtk_expanded_container_unittest.cc View 1 chunk +0 lines, -159 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/infobar_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/slide_animator_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tab_contents_container_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
A + ui/base/gtk/gtk_expanded_container.h View 2 chunks +16 lines, -12 lines 0 comments Download
A + ui/base/gtk/gtk_expanded_container.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/base/gtk/gtk_expanded_container_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ui.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ui_unittests.gypi View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
Just like the other one. (The trybot list seems to be incorrect; here's the real ...
9 years, 4 months ago (2011-08-24 23:11:20 UTC) #1
jam
9 years, 4 months ago (2011-08-24 23:40:53 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698