Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 7739020: Rename scanner.* to scanner-character-streams.* and scanner-base.* to scanner.* (Closed)

Created:
9 years, 3 months ago by tfarina
Modified:
9 years, 3 months ago
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Rename scanner.* to scanner-character-streams.*. and scanner-base.* to scanner.* R=lrn@chromium.org Signed-off-by: Thiago Farina <tfarina@chromium.org>; Committed: http://code.google.com/p/v8/source/detail?r=9195

Patch Set 1 : #

Total comments: 1

Patch Set 2 : rename scanner-base to scanner #

Patch Set 3 : fix include guard of scanner #

Patch Set 4 : rename scanner.* again to scanner-character-streams.* #

Patch Set 5 : rename scanner-base.* to scanner.* #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1520 lines, -1970 lines) Patch
M src/SConscript View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/api.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/conversions.h View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M src/conversions.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M src/conversions-inl.h View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M src/dateparser.h View 1 4 1 chunk +0 lines, -1 line 0 comments Download
M src/heap.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.cc View 1 4 1 chunk +0 lines, -1 line 0 comments Download
M src/parser.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/parser.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/preparser.h View 1 2 3 4 2 chunks +9 lines, -1 line 0 comments Download
M src/preparser.cc View 1 2 3 4 1 chunk +7 lines, -9 lines 0 comments Download
M src/preparser-api.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M src/scanner.h View 1 2 3 4 1 chunk +497 lines, -62 lines 0 comments Download
M src/scanner.cc View 1 4 1 chunk +980 lines, -216 lines 0 comments Download
D src/scanner-base.h View 1 2 3 4 1 chunk +0 lines, -564 lines 0 comments Download
D src/scanner-base.cc View 1 4 1 chunk +0 lines, -1090 lines 0 comments Download
A + src/scanner-character-streams.h View 1 4 2 chunks +4 lines, -4 lines 0 comments Download
A + src/scanner-character-streams.cc View 1 4 1 chunk +2 lines, -1 line 0 comments Download
M src/v8conversions.cc View 1 4 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tfarina
9 years, 3 months ago (2011-09-05 14:01:27 UTC) #1
Erik Corry
Why is this an improvement?
9 years, 3 months ago (2011-09-05 17:05:25 UTC) #2
Erik Corry
http://codereview.chromium.org/7739020/diff/2001/src/scanner-character-streams.cc File src/scanner-character-streams.cc (right): http://codereview.chromium.org/7739020/diff/2001/src/scanner-character-streams.cc#newcode30 src/scanner-character-streams.cc:30: #include "scanner-character-streams.h" We try to keep these in alphabetical ...
9 years, 3 months ago (2011-09-05 17:07:38 UTC) #3
tfarina
On 2011/09/05 17:05:25, Erik Corry wrote: > Why is this an improvement? http://codereview.chromium.org/7835019/diff/1/src/scanner.h#newcode29
9 years, 3 months ago (2011-09-05 17:14:04 UTC) #4
Lasse Reichstein
Rename scanner-base* to scanner*, then it'll LGTM.
9 years, 3 months ago (2011-09-06 07:28:21 UTC) #5
tfarina
On 2011/09/06 07:28:21, Lasse Reichstein wrote: > Rename scanner-base* to scanner*, then it'll LGTM. Done. ...
9 years, 3 months ago (2011-09-06 14:41:54 UTC) #6
tfarina
ping? Do you want me to revert patch set 3 to patch set 1 for ...
9 years, 3 months ago (2011-09-07 15:07:37 UTC) #7
Lasse Reichstein
I think the rename is fine, but the patch doesn't seem to apply to the ...
9 years, 3 months ago (2011-09-08 07:35:13 UTC) #8
tfarina
On 2011/09/08 07:35:13, Lasse Reichstein wrote: > I think the rename is fine, but the ...
9 years, 3 months ago (2011-09-08 11:47:24 UTC) #9
Lasse Reichstein
9 years, 3 months ago (2011-09-08 13:02:12 UTC) #10
LGTM, I'll land it.

Powered by Google App Engine
This is Rietveld 408576698