Issue 7739016: aura-views: Make views_aura_desktop compile and run on linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7739016: aura-views: Make views_aura_desktop compile and run on linux. (Closed)

Created:
9 years, 3 months ago by sadrul

Modified:
9 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, dhollowa, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

aura-views: Make views_aura_desktop compile and run on linux. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99901

Patch Set 3 : . #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -4 lines)			Patch
M	ui/gfx/canvas_skia_linux.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/platform_font_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	views/aura_desktop/aura_desktop_main.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	views/controls/menu/menu_controller.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	views/controls/menu/menu_controller.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
A	views/drag_utils_linux.cc	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	views/views.gyp	View	1 2	5 chunks	+12 lines, -0 lines	0 comments	Download
M	views/window/dialog_client_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sadrul

I excluded accelerator_handler_aura.cc sky@: Please review. ben@: FYI.

9 years, 3 months ago (2011-09-05 01:56:20 UTC) #1

sky

http://codereview.chromium.org/7739016/diff/1/views/views.gyp File views/views.gyp (right): http://codereview.chromium.org/7739016/diff/1/views/views.gyp#newcode460 views/views.gyp:460: 'drag_utils_linux.cc', List this above with all files.

9 years, 3 months ago (2011-09-06 15:00:51 UTC) #2

sadrul

9 years, 3 months ago (2011-09-06 15:41:42 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 7739016: aura-views: Make views_aura_desktop compile and run on linux. (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Messages