Issue 7739007: ntp4: app generation tweak

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7739007: ntp4: app generation tweak (Closed)

Created:
9 years, 3 months ago by Evan Stade

Modified:
9 years, 3 months ago

Reviewers:
Greg Billock

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

ntp4: app generation tweak if there was no title and the URL was >45 chars then the app generation would fail. Also, make the extent more specific (i.e. equal to the launch url), so for example you can install a google reader app (will not conflict with cloud print). BUG=none TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99766

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : fix for overlapping extents #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	chrome/browser/resources/ntp4/apps_page.js	View	1	1 chunk	+5 lines, -6 lines	0 comments	Download
	M	chrome/browser/ui/webui/ntp/app_launcher_handler.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

Greg, did you already change the URL to not add a wildcard (I don't see ...

9 years, 3 months ago (2011-09-02 23:01:36 UTC) #1

Evan Stade

On 2011/09/02 23:01:36, Evan Stade wrote: > Greg, did you already change the URL to ...

9 years, 3 months ago (2011-09-02 23:42:28 UTC) #2

Greg Billock

9 years, 3 months ago (2011-09-06 14:40:12 UTC) #3

LGTM

No, I hadn't made that cl. Thanks.

On 2011/09/02 23:42:28, Evan Stade wrote:
> On 2011/09/02 23:01:36, Evan Stade wrote:
> > Greg, did you already change the URL to not add a wildcard (I don't see it
> here,
> > but I want to make sure it's not doing it somewhere else).
> 
> nevermind, done.

Expand Messages | Collapse Messages