chrome/browser/ui/gtk/gtk_theme_service.cc - Issue 7739001: Remove redundant allocation and SkBitmap copy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/gtk_theme_service.cc

Issue 7739001: Remove redundant allocation and SkBitmap copy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/gtk_theme_service.cc

diff --git a/chrome/browser/ui/gtk/gtk_theme_service.cc b/chrome/browser/ui/gtk/gtk_theme_service.cc

index a09d79a7bf7240f7f1b84dc837387de94b6c09fe..a3d58dab07dfaf032304ab4f42a4fdfa7d2ace36 100644

--- a/chrome/browser/ui/gtk/gtk_theme_service.cc

+++ b/chrome/browser/ui/gtk/gtk_theme_service.cc

@@ -1080,9 +1080,8 @@ SkBitmap* GtkThemeService::GenerateTintedIcon(

int base_id,

const color_utils::HSL& tint) const {

ResourceBundle& rb = ResourceBundle::GetSharedInstance();

- scoped_ptr<SkBitmap> button(new SkBitmap(*rb.GetBitmapNamed(base_id)));

return new SkBitmap(SkBitmapOperations::CreateHSLShiftedBitmap(

- *button, tint));

+ *rb.GetBitmapNamed(base_id), tint));

}

void GtkThemeService::GetNormalButtonTintHSL(

« no previous file with comments | « no previous file | no next file » | no next file with comments »