Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: ppapi/native_client/tests/ppapi_browser/crash/nacl.scons

Issue 7736016: Revert 98616 - Landing chrome side of nacl change pre-dating ppapi switch. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/tests/ppapi_browser/crash/nacl.scons
===================================================================
--- ppapi/native_client/tests/ppapi_browser/crash/nacl.scons (revision 98628)
+++ ppapi/native_client/tests/ppapi_browser/crash/nacl.scons (working copy)
@@ -11,8 +11,6 @@
Import('env')
env.Prepend(CPPDEFINES=['XP_UNIX'])
-env.Replace(
- TEST_DIR='${SOURCE_ROOT}/ppapi/native_client/tests/ppapi_browser/crash')
crash_types = ['via_check_failure',
'via_exit_call',
@@ -21,7 +19,6 @@
'ppapi_off_main_thread']
published_files = []
-nmfs = []
for crash_type in crash_types:
nexe = 'ppapi_crash_%s_%s' % (crash_type, env.get('TARGET_FULLARCH'))
env.Alias('ppapi_crash_%s${PROGSUFFIX}' % crash_type,
@@ -39,19 +36,17 @@
# TODO(polina): follow ppapi_browser/bad nacl.scons to publish html only once
# and to associate all nexes and nmf files with one target that can be
# referenced in tests/nacl.scons.
- nmfs.append('${TEST_DIR}/ppapi_crash_%s.nmf' % crash_type)
env.Publish(nexe, 'run',
- ['ppapi_crash.html'])
+ ['ppapi_crash.html',
+ 'ppapi_crash_%s.nmf' % crash_type ])
published_files.extend(env.ExtractPublishedFiles(nexe))
node = env.PPAPIBrowserTester('ppapi_crash_browser_test.out',
url='ppapi_crash.html',
- nmf=nmfs,
files=published_files)
env.AddNodeToTestSuite(node,
['chrome_browser_tests'],
'run_ppapi_crash_browser_test',
- is_broken=env.PPAPIBrowserTesterIsBroken() or
- env.Bit('nacl_glibc'))
+ is_broken=env.PPAPIBrowserTesterIsBroken())

Powered by Google App Engine
This is Rietveld 408576698