Issue 7736014: [cros] Process proper notification in SIM dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7736014: [cros] Process proper notification in SIM dialog. (Closed)

Created:
9 years, 3 months ago by Nikita (slow)

Modified:
9 years, 3 months ago

Reviewers:
Dmitry Polukhin

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[cros] Process proper notification in SIM dialog. This eliminates unnecessary dialog refreshes when input is lost and user has to enter it again. Small JS change, properly disable OK controls in SIM dialogs. BUG=chrome-os-partner:4661 TEST=Manual. Various operations with SIM dialog. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98641

Patch Set 1 #

Patch Set 2 : formatting #

Patch Set 3 : proper fix #

Patch Set 4 : comment #

Patch Set 5 : small js change #

Patch Set 6 : more fixes #

Patch Set 7 : js focus fix #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -10 lines)			Patch
M	chrome/browser/chromeos/cros/network_library.h	View	1 2 3	1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_library.cc	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/chromeos/sim_unlock.js	View	1 2 3 4 5 6	6 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc	View	1 2 3 4 5	6 chunks	+21 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

Please take a look, proper fix now. Update dialog state only on single property change ...

9 years, 3 months ago (2011-08-29 12:25:54 UTC) #2

LGTM

Expand Messages | Collapse Messages