Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 7736003: Revert 98539 (Closed)

Created:
9 years, 4 months ago by Nico
Modified:
9 years, 4 months ago
Reviewers:
mmenke
CC:
chromium-reviews, tburkard+watch_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, mmenke, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 98539 Test fails consistently on Linux Views bots: PrerenderBrowserTest.PrerenderVisibilityBackgroundTab: [6686:6686:0826/200949:368667468:WARNING:zygote_host_linux.cc(148)] Running without the SUID sandbox! See http://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on. [6686:6686:0826/200949:368753313:WARNING:proxy_config_service_impl.cc(654)] Error retrieving proxy setting from device [6686:6686:0826/200949:368754972:WARNING:wm_ipc.cc(311)] Missing _CHROME_LAYOUT_MODE property on root window [6686:6691:0826/200949:368757012:INFO:gl_implementation.cc(94)] Using desktop GL implementation. [6686:6691:0826/200949:368762612:ERROR:gl_surface_glx.cc(64)] GLX 1.3 or later is required. [6686:6691:0826/200949:368762779:ERROR:gl_surface_linux.cc(73)] GLSurfaceGLX::InitializeOneOff failed. [6686:6691:0826/200949:368762962:ERROR:gpu_info_collector_linux.cc(216)] gfx::GLContext::InitializeOneOff() failed [6686:6686:0826/200949:368808876:ERROR:timezone_settings.cc(61)] GetTimezoneID: Cannot read timezone symlink /var/lib/timezone/localtime [6686:6686:0826/200949:368808913:ERROR:timezone_settings.cc(141)] Got an empty string for timezone, default to America/Los_Angeles [6686:6686:0826/200949:368816216:WARNING:input_method_manager.cc(146)] No active input methods found. [6686:6686:0826/200949:368818013:WARNING:input_method_manager.cc(146)] No active input methods found. [6686:6686:0826/200949:368818259:WARNING:input_method_manager.cc(146)] No active input methods found. [6686:6686:0826/200950:369084812:WARNING:native_widget_gtk.cc(418)] compositing not supported; allowing anyway chrome/browser/prerender/prerender_browsertest.cc:680: Failure Value of: display_test_result Actual: false Expected: true - Deflake PrerenderExcessiveMemory, fixing a race in setting the visibility state of prerendered RenderViews in the process. Also add some more visibility API tests that would have reliably failed when losing the fixed race. BUG=93081 TEST=PrerenderBrowserTest.PrerenderExcessiveMemory. PrerenderBrowserTest.PrerenderInfiniteLoop Review URL: http://codereview.chromium.org/7693029 TBR=mmenke@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -131 lines) Patch
M chrome/browser/prerender/prerender_browsertest.cc View 11 chunks +28 lines, -51 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.h View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 6 chunks +23 lines, -10 lines 0 comments Download
D chrome/test/data/prerender/prerender_visibility_hidden_quick.html View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/test/data/prerender/prerender_visibility_quick.html View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nico
9 years, 4 months ago (2011-08-27 04:35:07 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698