Issue 7734005: Get rid of the link time dependency between content and chrome through the geolocation code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7734005: Get rid of the link time dependency between content and chrome through the geolocation code. (Closed)

Created:
9 years, 3 months ago by jam

Modified:
9 years, 3 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Get rid of the link time dependency between content and chrome through the geolocation code. BUG=76697 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98151

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+150 lines, -125 lines)			Patch
M	chrome/browser/chrome_content_browser_client.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chrome_content_browser_client.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
D	chrome/browser/geolocation/access_token_store.cc	View		1 chunk	+0 lines, -110 lines	0 comments	Download
M	chrome/browser/geolocation/access_token_store_browsertest.cc	View	1 2	4 chunks	+4 lines, -6 lines	0 comments	Download
A	chrome/browser/geolocation/chrome_access_token_store.h	View		1 chunk	+34 lines, -0 lines	0 comments	Download
A	chrome/browser/geolocation/chrome_access_token_store.cc	View		1 chunk	+68 lines, -0 lines	0 comments	Download
M	chrome/browser/geolocation/geolocation_prefs.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/content_browser_client.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/browser/geolocation/access_token_store.h	View		2 chunks	+0 lines, -5 lines	0 comments	Download
A	content/browser/geolocation/access_token_store.cc	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download
M	content/browser/geolocation/arbitrator_dependency_factory.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/mock_content_browser_client.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/mock_content_browser_client.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/content_browser.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages