Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3890)

Unified Diff: chrome/browser/ui/cocoa/browser_window_utils.mm

Issue 7734003: Implement basic theming for panel titlebars. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_utils.h ('k') | chrome/browser/ui/cocoa/chrome_browser_window.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_utils.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_utils.mm b/chrome/browser/ui/cocoa/browser_window_utils.mm
index c02861544c9f7cb84ceeb9122f80a374787c493c..aea2e9b8324507ea22c11bed6675b918eeb2a3d3 100644
--- a/chrome/browser/ui/cocoa/browser_window_utils.mm
+++ b/chrome/browser/ui/cocoa/browser_window_utils.mm
@@ -10,6 +10,7 @@
#include "chrome/browser/ui/browser.h"
#import "chrome/browser/ui/cocoa/chrome_event_processing_window.h"
#import "chrome/browser/ui/cocoa/nsmenuitem_additions.h"
+#import "chrome/browser/ui/cocoa/tabs/tab_strip_controller.h"
#include "content/common/native_web_keyboard_event.h"
@interface MenuWalker : NSObject
@@ -121,4 +122,57 @@
return [event_window redispatchKeyEvent:event];
}
++ (NSString*)scheduleReplaceOldTitle:(NSString*)oldTitle
+ withNewTitle:(NSString*)newTitle
+ forWindow:(NSWindow*)window {
+ if (oldTitle)
+ [[NSRunLoop currentRunLoop]
+ cancelPerformSelector:@selector(setTitle:)
+ target:window
+ argument:oldTitle];
+
+ [[NSRunLoop currentRunLoop]
+ performSelector:@selector(setTitle:)
+ target:window
+ argument:newTitle
+ order:0
+ modes:[NSArray arrayWithObject:NSDefaultRunLoopMode]];
+ return [newTitle copy];
Nico 2013/03/04 14:07:02 Doesn't this leak? Who frees this?
+}
+
+// Our patterns want to be drawn from the upper left hand corner of the view.
+// Cocoa wants to do it from the lower left of the window.
+//
+// Rephase our pattern to fit this view. Some other views (Tabs, Toolbar etc.)
+// will phase their patterns relative to this so all the views look right.
+//
+// To line up the background pattern with the pattern in the browser window
+// the background pattern for the tabs needs to be moved left by 5 pixels.
+const CGFloat kPatternHorizontalOffset = -5;
+// To match Windows and CrOS, have to offset vertically by 2 pixels.
+// Without tab strip, offset an extra pixel (determined by experimentation).
+const CGFloat kPatternVerticalOffset = 2;
+const CGFloat kPatternVerticalOffsetNoTabStrip = 3;
+
+
++ (NSPoint)themePatternPhaseFor:(NSView*)windowView
+ withTabStrip:(NSView*)tabStripView {
+ // When we have a tab strip, line up with the top of the tab, otherwise,
+ // line up with the top of the window.
+ if (!tabStripView)
+ return NSMakePoint(kPatternHorizontalOffset,
+ NSHeight([windowView bounds])
+ + kPatternVerticalOffsetNoTabStrip);
+
+ NSRect tabStripViewWindowBounds = [tabStripView bounds];
+ tabStripViewWindowBounds =
+ [tabStripView convertRect:tabStripViewWindowBounds
+ toView:windowView];
+ return NSMakePoint(NSMinX(tabStripViewWindowBounds)
+ + kPatternHorizontalOffset,
+ NSMinY(tabStripViewWindowBounds)
+ + [TabStripController defaultTabHeight]
+ + kPatternVerticalOffset);
+}
+
@end
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_utils.h ('k') | chrome/browser/ui/cocoa/chrome_browser_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698