Implement basic theming for panel titlebars.

chrome/browser/ui/cocoa/browser_window_cocoa.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/sys_string_conversions.h"
@@ skipping 185 matching lines @@
   // download shelf was a ChromeView attached to the TabContents, and as its
   // size changed via animation it notified through TCD/etc to the browser view
   // to relayout for each tick of the animation. We don't need anything of the
   // sort on Mac.
 }
 
 void BrowserWindowCocoa::UpdateTitleBar() {
   NSString* newTitle =
       base::SysUTF16ToNSString(browser_->GetWindowTitleForCurrentTab());
 
-  // Work around Cocoa bug: if a window changes title during the tracking of the
-  // Window menu it doesn't display well and the constant re-sorting of the list
-  // makes it difficult for the user to pick the desired window. Delay window
-  // title updates until the default run-loop mode.
-
-  if (pending_window_title_.get())
-    [[NSRunLoop currentRunLoop]
-        cancelPerformSelector:@selector(setTitle:)
-                       target:window()
-                     argument:pending_window_title_.get()];
-
-  pending_window_title_.reset([newTitle copy]);
-  [[NSRunLoop currentRunLoop]
-      performSelector:@selector(setTitle:)
-               target:window()
-             argument:newTitle
-                order:0
-                modes:[NSArray arrayWithObject:NSDefaultRunLoopMode]];
+  [BrowserWindowUtils delayedReplace:pending_window_title_.get()

[Dmitry Titov, 2011/08/31 01:01:30]

Naming suggestion: Usually 'delayedFoo' is associated with literal time-based
delay... How about:
[BrowserWindowUtils scheduleTitleChangeForWindow:window newTitle:newTitle
previouslyScheduledTitle:previousTitle]?

It can also return a new copy of the title, if that makes code more readable :-)

[dcheng, 2011/08/31 23:58:03]

Done. Now with a longer more verbose name.

+                                with:newTitle
+                                  on:window()];
 }
 
 void BrowserWindowCocoa::BookmarkBarStateChanged(
     BookmarkBar::AnimateChangeType change_type) {
   // TODO: route changes to state through this.
 }
 
 void BrowserWindowCocoa::UpdateDevTools() {
   [controller_ updateDevToolsForContents:
       browser_->GetSelectedTabContents()];
@@ skipping 344 matching lines @@
 
 NSWindow* BrowserWindowCocoa::window() const {
   return [controller_ window];
 }
 
 void BrowserWindowCocoa::UpdateSidebarForContents(TabContents* tab_contents) {
   if (tab_contents == browser_->GetSelectedTabContents()) {
     [controller_ updateSidebarForContents:tab_contents];
   }
 }