Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 7730006: Fixed the issue in the script:special_tabs.SpecialTabsTest.testSpecialURLRedirects (Closed)

Created:
9 years, 4 months ago by rayanna
Modified:
9 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M PYAUTO_TESTS View 1 1 chunk +7 lines, -0 lines 0 comments Download
M special_tabs.py View 1 2 2 chunks +11 lines, -11 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
rayanna
Disabled the failed test.
9 years, 4 months ago (2011-08-24 20:44:36 UTC) #1
rayanna
Fixed the issue in the script: special_tabs.SpecialTabsTest.testSpecialURLRedirects and done with required change in the script ...
9 years, 4 months ago (2011-08-26 00:25:06 UTC) #2
Nirnimesh
Remove "Description" from the Description. http://codereview.chromium.org/7730006/diff/6002/special_tabs.py File special_tabs.py (right): http://codereview.chromium.org/7730006/diff/6002/special_tabs.py#newcode23 special_tabs.py:23: 'about:': 'chrome://version', Why?
9 years, 4 months ago (2011-08-26 01:23:13 UTC) #3
Nirnimesh
LGTM
9 years, 4 months ago (2011-08-26 01:23:19 UTC) #4
commit-bot: I haz the power
Change committed as 98490
9 years, 4 months ago (2011-08-26 21:21:06 UTC) #5
Nirnimesh
9 years, 4 months ago (2011-08-26 23:11:56 UTC) #6
testprocessCountAppendSingleTab is spelt wrongly.
Please be careful with these. At least make sure that they go fine on the bots
after committing. The bots are broken right now because of this.

Powered by Google App Engine
This is Rietveld 408576698