Issue 7729006: Deflake and add more prerender_browsertests focused on back navigation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7729006: Deflake and add more prerender_browsertests focused on back navigation. (Closed)

Created:
9 years, 4 months ago by mmenke

Modified:
9 years, 3 months ago

Reviewers:
cbentzel, commit-bot: I haz the power

CC:
chromium-reviews, tburkard+watch_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, mmenke, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Deflake prerender_browsertests focused on back navigation, and add some more. R=cbentzel BUG=89798 TEST=browser_tests --gtest_filter=*GoBack Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98821

Patch Set 1 : Basically same as original CL #

Patch Set 2 : Fix background tab tests, still need to fix others on Mac #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 1

Patch Set 5 : Stop waiting for callback from RenderView we're killing. #

Patch Set 6 : Add comment #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+229 lines, -98 lines)			Patch
M	chrome/browser/prerender/prerender_browsertest.cc	View	1 2 3 4 5	5 chunks	+181 lines, -89 lines	0 comments	Download
M	chrome/test/data/prerender/prerender_loader.html	View	1 2 3 4	1 chunk	+44 lines, -7 lines	0 comments	Download
M	chrome/test/data/prerender/prerender_page_with_link.html	View	1 2 3 4	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mmenke

Looks like the flake was caused by ExecuteJavaScriptAndExtractBool waiting for the RenderView to respond. At ...

9 years, 3 months ago (2011-08-29 21:42:23 UTC) #1

cbentzel

LGTM Thanks. http://codereview.chromium.org/7729006/diff/11001/chrome/browser/prerender/prerender_browsertest.cc File chrome/browser/prerender/prerender_browsertest.cc (right): http://codereview.chromium.org/7729006/diff/11001/chrome/browser/prerender/prerender_browsertest.cc#newcode455 chrome/browser/prerender/prerender_browsertest.cc:455: #if defined(OS_MACOSX) Oops!

9 years, 3 months ago (2011-08-30 13:44:53 UTC) #2

Change committed as 98821

Expand Messages | Collapse Messages