Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: content/browser/renderer_host/render_view_host.cc

Issue 7729002: Handle the ViewHostMsg_RunFileChooser IPC message which is sent by content(renderer) in RVH and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host.cc
===================================================================
--- content/browser/renderer_host/render_view_host.cc (revision 98068)
+++ content/browser/renderer_host/render_view_host.cc (working copy)
@@ -718,10 +718,14 @@
#if defined(OS_MACOSX)
IPC_MESSAGE_HANDLER(ViewHostMsg_ShowPopup, OnMsgShowPopup)
#endif
+ IPC_MESSAGE_HANDLER(ViewHostMsg_RunFileChooser, OnRunFileChooser)
+
// Have the super handle all other messages.
IPC_MESSAGE_UNHANDLED(handled = RenderWidgetHost::OnMessageReceived(msg))
- // NOTE: Do not add a message handler that just calls the delegate!
+
jam 2011/08/24 20:30:29 why add this blank line? and also above
ananta 2011/08/24 20:38:05 Removed both lines
+ // NOTE: Do not add a message handler that just calls the delegate!,
// Dispatch the message directly there instead.
+ // This does not apply to messages sent by content.
jam 2011/08/24 20:30:29 if you add this line, please explain why that's th
ananta 2011/08/24 20:38:05 I removed the whole comment as delegates can live
IPC_END_MESSAGE_MAP_EX()
if (!msg_is_ok) {
@@ -1357,3 +1361,9 @@
}
}
#endif
+
+void RenderViewHost::OnRunFileChooser(
+ const ViewHostMsg_RunFileChooser_Params& params) {
+ delegate_->RunFileChooser(this, params);
+}
+
« no previous file with comments | « content/browser/renderer_host/render_view_host.h ('k') | content/browser/renderer_host/render_view_host_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698