Issue 7727004: Initialize content scripts the same way extension scripts are.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7727004: Initialize content scripts the same way extension scripts are. (Closed)

Created:
9 years, 4 months ago by Aaron Boodman

Modified:
9 years, 4 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Initialize content scripts the same way extension scripts are. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98469

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -72 lines)			Patch
M	chrome/renderer/extensions/event_bindings.cc	View	2 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/renderer/extensions/extension_process_bindings.cc	View	2 chunks	+0 lines, -16 lines	0 comments	Download
M	chrome/renderer/extensions/user_script_idle_scheduler.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/renderer/extensions/user_script_slave.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/renderer/extensions/user_script_slave.cc	View	4 chunks	+4 lines, -19 lines	0 comments	Download
M	chrome/renderer/resources/event_bindings.js	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/renderer/resources/extension_process_bindings.js	View	3 chunks	+3 lines, -19 lines	1 comment	Download
M	chrome/renderer/resources/renderer_extension_bindings.js	View	2 chunks	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

9 years, 4 months ago (2011-08-24 22:11:34 UTC) #2

LGTM

http://codereview.chromium.org/7727004/diff/1/chrome/renderer/resources/exten...
File chrome/renderer/resources/extension_process_bindings.js (right):

http://codereview.chromium.org/7727004/diff/1/chrome/renderer/resources/exten...
chrome/renderer/resources/extension_process_bindings.js:580: if
(!isExtensionProcess)
not all the extension-specific code is in this listener. see the end of the
file: we'll still end up exposing a stubbed-out chrome.experimental, chrome.tts,
etc. though maybe that's OK?

Expand Messages | Collapse Messages