Issue 7727001: Adds yet more debugging in hopes of tracking 91396. The latest data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7727001: Adds yet more debugging in hopes of tracking 91396. The latest data (Closed)

Created:
9 years, 4 months ago by sky

Modified:
9 years, 4 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, dhollowa, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Adds yet more debugging in hopes of tracking 91396. The latest data indicates FindPreference is returning NULL and we're in shutdown because the last window is being closed. I suspect that for some reason on some machines this triggers us to get a WM_CLOSE after we've removed the property used to lookup the profile (removed in WM_DESTROY) so that we fall back to the local state prefs which don't have a property for window position and we crash. I'm adding debugging code to determine whether that is in fact happening. BUG=91396 TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98180

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -4 lines)			Patch
M	chrome/browser/ui/views/chrome_views_delegate.cc	View	1 2 3 4	3 chunks	+10 lines, -3 lines	0 comments	Download
M	views/widget/widget.h	View		3 chunks	+20 lines, -0 lines	0 comments	Download
M	views/widget/widget.cc	View		2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages

Issue 7727001: Adds yet more debugging in hopes of tracking 91396. The latest data (Closed)

Description

Patch Set 1 #

Patch Set 2 : Relative patch #

Patch Set 3 : Remove turning off compositor #

Patch Set 4 : Merge to trunk #

Patch Set 5 : Add back include merge stripped out #

Messages