Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4076)

Unified Diff: chrome/chrome.gyp

Issue 7726007: Don't build the main executable binaries as Objective-C (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chrome_main_posix.cc ('k') | chrome/chrome_exe.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome.gyp
===================================================================
--- chrome/chrome.gyp (revision 98121)
+++ chrome/chrome.gyp (working copy)
@@ -943,15 +943,15 @@
'infoplist_strings_tool',
],
'sources': [
- # chrome_exe_main_mac.mm's main() is the entry point for
+ # chrome_exe_main_mac.cc's main() is the entry point for
# the "chrome" (browser app) target. All it does is jump
# to chrome_dll's ChromeMain. This is appropriate for
# helper processes too, because the logic to discriminate
# between process types at run time is actually directed
# by the --type command line argument processed by
- # ChromeMain. Sharing chrome_exe_main_mac.mm with the
+ # ChromeMain. Sharing chrome_exe_main_mac.cc with the
# browser app will suffice for now.
- 'app/chrome_exe_main_mac.mm',
+ 'app/chrome_exe_main_mac.cc',
'app/helper-Info.plist',
],
# TODO(mark): Come up with a fancier way to do this. It should only
@@ -1017,6 +1017,14 @@
'<(branding)',
'<(mac_bundle_id)'],
},
+ {
+ # Make sure there isn't any Objective-C in the helper app's
+ # executable.
+ 'postbuild_name': 'Verify No Objective-C',
+ 'action': [
+ 'tools/build/mac/verify_no_objc.sh',
+ ],
+ },
],
'conditions': [
['mac_breakpad==1', {
« no previous file with comments | « chrome/app/chrome_main_posix.cc ('k') | chrome/chrome_exe.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698