DescriptionDon't build the main executable binaries as Objective-C.
The operative portion of this change simply renames
chrome/app/chrome_exe_main_mac.mm to chrome/app/chrome_exe_main_mac.cc. The
main executables never used any Objective-C anyway. I named the files with .mm
a long time ago because at the time it meant that I didn't need to add a
separate GYP 'exclude' rule to keep other platforms from seeing the file. That
was before we added the rules to automatically exclude files based on platform
suffix like _mac.
This change also adds a "verify" step to the targets that build our main
executables. The verify step will cause a build failure if this ever
regresses.
This works around a bug in 10.5 CFBundlePreflightExecutable, which crashes
when called in a process whose main executable has slid due to PIE when the
main executable also contains an __OBJC,__image_info section. We enabled PIE
at r91243.
BUG=88697
TEST=No more crashes inside CFBundlePreflightExecutable (on our call from
webkit::npapi::PluginLib::ReadWebPluginInfo) on 10.5
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98122
Patch Set 1 #
Total comments: 1
Patch Set 2 : '' #
Messages
Total messages: 5 (0 generated)
|