Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 7726003: Block {am, fa, sw} and {kn, te} on CrOS. (Closed)

Created:
9 years, 4 months ago by jungshik at Google
Modified:
9 years, 4 months ago
Reviewers:
tony
CC:
chromium-reviews, ginsberg, yoshiki, Yusuke Sato
Visibility:
Public.

Description

Block {am, fa, sw} and {kn, te} on CrOS and roll ICU to 98343 The former is blocked until we have translation back for them. For ChromeOS R14, we'll not have them ready. The former is blocked until we have fonts for them to use on CrOS. This change will be reverted once two issues above are resolved. See http://codereview.chromium.org/7725002/ for the ICU part that removed the CrOS-specific ICU data file. BUG=chromium-os:19465 TEST=The UI language list does not include the above 5 languages on CrOS. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98435

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util_posix.cc View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jungshik at Google
9 years, 4 months ago (2011-08-24 22:00:50 UTC) #1
tony
Should we just change this on the branch?
9 years, 4 months ago (2011-08-24 22:03:42 UTC) #2
tony
9 years, 4 months ago (2011-08-24 22:07:34 UTC) #3
The change LGTM if you think it's better to just make the change on trunk.

http://codereview.chromium.org/7726003/diff/1/ui/base/l10n/l10n_util_posix.cc
File ui/base/l10n/l10n_util_posix.cc (right):

http://codereview.chromium.org/7726003/diff/1/ui/base/l10n/l10n_util_posix.cc...
ui/base/l10n/l10n_util_posix.cc:25: for (int i = 0; i < kUnsupportedLocalesLen;
++i) {
Nit: I would just inline arraysize(kUnsupportedLocaleLen) here.

Powered by Google App Engine
This is Rietveld 408576698