Issue 7725006: Print Preview: Fix the entry in about:flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7725006: Print Preview: Fix the entry in about:flags. (Closed)

Created:
9 years, 4 months ago by Lei Zhang

Modified:
9 years, 4 months ago

Reviewers:
Albert Bodenhamer

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Print Preview: Fix the entry in about:flags. BUG=94121 TEST=Print preview is on by default again. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98123

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
	M	chrome/browser/about_flags.cc	View		1 chunk	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

Albert, I want to apologize for the confusion - the comment for the print preview ...

9 years, 4 months ago (2011-08-24 20:44:21 UTC) #1

Albert Bodenhamer

9 years, 4 months ago (2011-08-24 21:20:25 UTC) #2

LGTM

Got it.  Looking at the history, I think you turned it back on for all platforms
after I had started this CL and I just missed it when merging.  Sorry about
that.

On 2011/08/24 20:44:21, Lei Zhang wrote:
> Albert, I want to apologize for the confusion - the comment for the print
> preview flag was out of date. We actually reverted back to having print
preview
> as a flag, so users with special printing needs who want to turn it off can do
> so. 
> 
> As such, the flag needs to be there for all platforms. We're working to hook
up
> the native print dialog to ctrl+shift+p, so we can remove print preview from
> about:flags on Google Chrome Win/Mac/Linux.

Expand Messages | Collapse Messages