Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Side by Side Diff: icu.gyp

Issue 7725002: Remove a separate ICU data file for CrOS. (Closed) Base URL: svn://chrome-svn/chrome/trunk/deps/third_party/icu46/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « cros/data/locales/te.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'use_system_icu%': 0, 7 'use_system_icu%': 0,
8 'icu_use_data_file_flag%': 0, 8 'icu_use_data_file_flag%': 0,
9 }, 9 },
10 'target_defaults': { 10 'target_defaults': {
(...skipping 30 matching lines...) Expand all
41 }, 41 },
42 'targets': [ 42 'targets': [
43 { 43 {
44 'target_name': 'icudata', 44 'target_name': 'icudata',
45 'type': '<(library)', 45 'type': '<(library)',
46 'sources': [ 46 'sources': [
47 # These are hand-generated, but will do for now. The linux 47 # These are hand-generated, but will do for now. The linux
48 # version is an identical copy of the (mac) icudt46l_dat.S file, 48 # version is an identical copy of the (mac) icudt46l_dat.S file,
49 # modulo removal of the .private_extern and .const directives and 49 # modulo removal of the .private_extern and .const directives and
50 # with no leading underscore on the icudt46_dat symbol. 50 # with no leading underscore on the icudt46_dat symbol.
51 # The ChromiumOS version is slightly smaller because it doesn't 51 # The ChromiumOS version is slightly smaller because it doesn't
TVL 2011/08/25 13:48:31 this comment is stale since the file is being remo
jungshik at Google 2011/08/25 22:30:33 Done.
52 # have locale data for locales Chrome is localized to but ChromeOS 52 # have locale data for locales Chrome is localized to but ChromeOS
53 # is not localized to. 53 # is not localized to.
54 'linux/icudt46l_dat.S', 54 'linux/icudt46l_dat.S',
55 'mac/icudt46l_dat.S', 55 'mac/icudt46l_dat.S',
TVL 2011/08/25 13:48:31 with both of these filtered, with chromeos switch
jungshik at Google 2011/08/25 22:30:33 You meant if ChromeOS will switch to using a data
56 'cros/icudt46l_dat.S',
57 ], 56 ],
58 'conditions': [ 57 'conditions': [
59 [ 'OS == "win"', { 58 [ 'OS == "win"', {
60 'type': 'none', 59 'type': 'none',
61 'copies': [ 60 'copies': [
62 { 61 {
63 'destination': '<(PRODUCT_DIR)', 62 'destination': '<(PRODUCT_DIR)',
64 'files': [ 63 'files': [
65 'windows/icudt.dll', 64 'windows/icudt.dll',
66 ], 65 ],
67 }, 66 },
68 ], 67 ],
69 }], 68 }],
70 [ 'OS == "win" or OS == "mac" or chromeos == 1', { 69 [ 'OS == "win" or OS == "mac"', {
71 'sources!': ['linux/icudt46l_dat.S'], 70 'sources!': ['linux/icudt46l_dat.S'],
72 }], 71 }],
73 [ 'OS != "mac"', { 72 [ 'OS != "mac"', {
74 'sources!': ['mac/icudt46l_dat.S'], 73 'sources!': ['mac/icudt46l_dat.S'],
75 }], 74 }],
76 [ 'chromeos != 1', {
77 'sources!': ['cros/icudt46l_dat.S'],
78 }],
79 [ 'OS != "win" and icu_use_data_file_flag', { 75 [ 'OS != "win" and icu_use_data_file_flag', {
80 # Remove any assembly data file. 76 # Remove any assembly data file.
81 'sources/': [['exclude', 'icudt46l_dat']], 77 'sources/': [['exclude', 'icudt46l_dat']],
82 # Compile in the stub data symbol. 78 # Compile in the stub data symbol.
83 'sources': ['source/stubdata/stubdata.c'], 79 'sources': ['source/stubdata/stubdata.c'],
84 # Make sure any binary depending on this gets the data file. 80 # Make sure any binary depending on this gets the data file.
85 'link_settings': { 81 'link_settings': {
86 'target_conditions': [ 82 'target_conditions': [
87 ['OS == "mac" and _mac_bundle', { 83 ['OS == "mac" and _mac_bundle', {
88 'mac_bundle_resources': [ 84 'mac_bundle_resources': [
(...skipping 460 matching lines...) Expand 10 before | Expand all | Expand 10 after
549 { 545 {
550 'target_name': 'icuuc', 546 'target_name': 'icuuc',
551 'type': 'none', 547 'type': 'none',
552 'dependencies': ['system_icu'], 548 'dependencies': ['system_icu'],
553 'export_dependent_settings': ['system_icu'], 549 'export_dependent_settings': ['system_icu'],
554 }, 550 },
555 ], 551 ],
556 }], 552 }],
557 ], 553 ],
558 } 554 }
OLDNEW
« no previous file with comments | « cros/data/locales/te.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698