Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 7725002: Remove a separate ICU data file for CrOS. (Closed)

Created:
9 years, 4 months ago by jungshik at Google
Modified:
9 years, 4 months ago
Reviewers:
TVL
CC:
chromium-reviews, yoshiki, Yusuke Sato, tony
Visibility:
Public.

Description

Remove a separate ICU data file for CrOS. The set of languages CrOS is localized to is now sync'd to the set of languages Chromium/Chrome is localized to. This will not be included until DEPS file is updated to roll this change in along with the following Chrome change ( http://codereview.chromium.org/7726003/ ) BUG=chromium-os:19465 TEST=ChromeOS build goes through. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98343

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -570 lines) Patch
M README.chromium View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D cros/README View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
D cros/data/curr/reslocal.mk View 1 2 1 chunk +0 lines, -68 lines 0 comments Download
D cros/data/lang/am.txt View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
D cros/data/lang/bn.txt View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
D cros/data/lang/fa.txt View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
D cros/data/lang/gu.txt View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
D cros/data/lang/kn.txt View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
D cros/data/lang/ml.txt View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
D cros/data/lang/mr.txt View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
D cros/data/lang/or.txt View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
D cros/data/lang/sw.txt View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
D cros/data/lang/ta.txt View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
D cros/data/lang/te.txt View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
D cros/data/locales/am.txt View 1 2 1 chunk +0 lines, -20 lines 0 comments Download
D cros/data/locales/bn.txt View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
D cros/data/locales/fa.txt View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
D cros/data/locales/gu.txt View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
D cros/data/locales/kn.txt View 1 2 1 chunk +0 lines, -25 lines 0 comments Download
D cros/data/locales/ml.txt View 1 2 1 chunk +0 lines, -25 lines 0 comments Download
D cros/data/locales/mr.txt View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
D cros/data/locales/or.txt View 1 2 1 chunk +0 lines, -25 lines 0 comments Download
D cros/data/locales/sw.txt View 1 2 1 chunk +0 lines, -21 lines 0 comments Download
D cros/data/locales/ta.txt View 1 2 1 chunk +0 lines, -24 lines 0 comments Download
D cros/data/locales/te.txt View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M icu.gyp View 1 2 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jungshik at Google
9 years, 4 months ago (2011-08-24 22:02:13 UTC) #1
TVL
lgtm with a comment cleanup. http://codereview.chromium.org/7725002/diff/4/icu.gyp File icu.gyp (right): http://codereview.chromium.org/7725002/diff/4/icu.gyp#newcode51 icu.gyp:51: # The ChromiumOS version ...
9 years, 4 months ago (2011-08-25 13:48:31 UTC) #2
jungshik at Google
9 years, 4 months ago (2011-08-25 22:30:33 UTC) #3
http://codereview.chromium.org/7725002/diff/4/icu.gyp
File icu.gyp (right):

http://codereview.chromium.org/7725002/diff/4/icu.gyp#newcode51
icu.gyp:51: # The ChromiumOS version is slightly smaller because it doesn't
On 2011/08/25 13:48:31, TVL wrote:
> this comment is stale since the file is being removed.

Done.

http://codereview.chromium.org/7725002/diff/4/icu.gyp#newcode55
icu.gyp:55: 'mac/icudt46l_dat.S',
On 2011/08/25 13:48:31, TVL wrote:
> with both of these filtered, with chromeos switch to using a data file?

You meant if ChromeOS will switch to using a data file later? I think we can
consider that (actually, I love to :-)).  However, we don't have a necessary
code change for that in Linux/ChromeOS, do we?

Powered by Google App Engine
This is Rietveld 408576698