Make the first character of the Task Manager kill button be underlined.

Make the first character of the Task Manager kill button be underlined.

BUG=92510
TEST=Make sure that the text "End Process" isn't preceded by an ampersand on Windows and has the E underlined.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98515

[msw, 2011-08-24 08:18:30]

This is great investigative work for your second day on Chrome; you're so close!

Reply with a message here when you've addressed the comment I made within the
diff (which is also automatically copied below); you should also send this up
for a try job, which would have caught the build error. I'll send you some extra
tips offline.

http://codereview.chromium.org/7723001/diff/1/chrome/browser/ui/views/task_ma...
File chrome/browser/ui/views/task_manager_view.cc (right):

http://codereview.chromium.org/7723001/diff/1/chrome/browser/ui/views/task_ma...
chrome/browser/ui/views/task_manager_view.cc:461:
kill_button_->set_prefix_type(PREFIX_SHOW);
You need to specify the full name views::TextButton::PREFIX_SHOW.

[gideonwald, 2011-08-24 23:12:09]

Hi Peter,

Mike's been helping me through the process of making a change, and I think I was
able to fix this minor string bug. He suggested I add you as a reviewer - would
love to hear your feedback.

Thanks!

-Gideon

[Peter Kasting, 2011-08-24 23:18:43]

LGTM, though I wonder if we ought to consider changing the global button default
from PREFIX_NONE to PREFIX_SHOW.

[Peter Kasting, 2011-08-24 23:19:43]

Oh, and P.S.: In the future make sure to use "@chromium.org" emails when adding
people to a public code review rather than "@google.com" (unless the reviewer in
question has no Chromium email).

[gideonwald, 2011-08-24 23:52:17]

Thanks, Peter! I'm going to try investigating a different bug to look at a new
part of the codebase, but I'll keep that suggestion in mind in case I have time
to come back to this one at any point.

Going to submit this once trybots finish.

[commit-bot: I haz the power, 2011-08-26 23:15:01]

Change committed as 98515