PrintPreview: Make ctrl-shift-p start the native print flow.

chrome/browser/ui/webui/print_preview_data_source.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/print_preview_data_source.h"
 
 #include <algorithm>
 
 #include "base/message_loop.h"
 #include "base/string_number_conversions.h"
 #include "base/string_piece.h"
 #include "base/string_split.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/printing/print_preview_data_service.h"
 #include "chrome/common/jstemplate_builder.h"
 #include "chrome/common/url_constants.h"
 #include "grit/browser_resources.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "grit/google_chrome_strings.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 
+namespace{
+
+#if defined(OS_MACOSX)
+// U+0028 U+21E7 U+2318 U+0050 U+0029 in UTF8
+const char kAdvancedPrintShortcut[] = "\x28\xE2\x8C\x98\xE2\x87\xA7\x50\x29";
+#endif
+
+};  // namespace
+
 PrintPreviewDataSource::PrintPreviewDataSource()
     : ChromeWebUIDataSource(chrome::kChromeUIPrintHost) {
 
   AddLocalizedString("title", IDS_PRINT_PREVIEW_TITLE);
   AddLocalizedString("loading", IDS_PRINT_PREVIEW_LOADING);
 #if defined(GOOGLE_CHROME_BUILD)
   AddString("noPlugin", l10n_util::GetStringFUTF16(
       IDS_PRINT_PREVIEW_NO_PLUGIN, ASCIIToUTF16("chrome://plugins/")));
 #else
   AddLocalizedString("noPlugin", IDS_PRINT_PREVIEW_NO_PLUGIN);
@@ skipping 34 matching lines @@
   AddLocalizedString("printPreviewSummaryFormatLong",
                      IDS_PRINT_PREVIEW_SUMMARY_FORMAT_LONG);
   AddLocalizedString("printPreviewSheetsLabelSingular",
                      IDS_PRINT_PREVIEW_SHEETS_LABEL_SINGULAR);
   AddLocalizedString("printPreviewSheetsLabelPlural",
                      IDS_PRINT_PREVIEW_SHEETS_LABEL_PLURAL);
   AddLocalizedString("printPreviewPageLabelSingular",
                      IDS_PRINT_PREVIEW_PAGE_LABEL_SINGULAR);
   AddLocalizedString("printPreviewPageLabelPlural",
                      IDS_PRINT_PREVIEW_PAGE_LABEL_PLURAL);
-  AddLocalizedString("systemDialogOption",
-                     IDS_PRINT_PREVIEW_SYSTEM_DIALOG_OPTION);
+#if defined(OS_MACOSX)
+  const string16 shortcut_text = UTF8ToUTF16(kAdvancedPrintShortcut);
+#else
+  const string16 shortcut_text =
+    l10n_util::GetStringUTF16(IDS_PRINT_PREVIEW_ADVANCED_SHORTCUT_KEY);

[Lei Zhang, 2011/08/25 20:43:23]

Since this doesn't need to be translated, just define it as
kAdvancedPrintShortcut instead of putting it in the .grd file.

[kmadhusu, 2011/08/25 22:47:39]

good catch.. Fixed.

+#endif
+  AddString("systemDialogOption", l10n_util::GetStringFUTF16(
+      IDS_PRINT_PREVIEW_SYSTEM_DIALOG_OPTION,
+      shortcut_text));
+
   AddLocalizedString("pageRangeInstruction",
                      IDS_PRINT_PREVIEW_PAGE_RANGE_INSTRUCTION);
   AddLocalizedString("copiesInstruction", IDS_PRINT_PREVIEW_COPIES_INSTRUCTION);
   AddLocalizedString("signIn", IDS_PRINT_PREVIEW_SIGN_IN);
   AddLocalizedString("morePrinters", IDS_PRINT_PREVIEW_MORE_PRINTERS);
   AddLocalizedString("addCloudPrinter", IDS_PRINT_PREVIEW_ADD_CLOUD_PRINTER);
   AddLocalizedString("cloudPrinters", IDS_PRINT_PREVIEW_CLOUD_PRINTERS);
   AddLocalizedString("localPrinters", IDS_PRINT_PREVIEW_LOCAL_PRINTERS);
   AddLocalizedString("manageCloudPrinters",
                      IDS_PRINT_PREVIEW_MANAGE_CLOUD_PRINTERS);
@@ skipping 38 matching lines @@
           url_substr[0], page_index, &data);
   }
   if (data.get()) {
     SendResponse(request_id, data);
     return;
   }
   // Invalid request.
   scoped_refptr<RefCountedBytes> empty_bytes(new RefCountedBytes);
   SendResponse(request_id, empty_bytes);
 }