Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: webkit/appcache/appcache_policy.h

Issue 7720022: Third-party appcache blocking. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Keeping up to date with trunk. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/appcache/appcache_host_unittest.cc ('k') | webkit/appcache/appcache_request_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/appcache/appcache_policy.h
diff --git a/webkit/appcache/appcache_policy.h b/webkit/appcache/appcache_policy.h
index 7d3e8442c4560d8443a169ee39e757c5f3e2e086..43a5dada551a1ee0ea304b25a219810389c4b984 100644
--- a/webkit/appcache/appcache_policy.h
+++ b/webkit/appcache/appcache_policy.h
@@ -5,8 +5,6 @@
#ifndef WEBKIT_APPCACHE_APPCACHE_POLICY_H_
#define WEBKIT_APPCACHE_APPCACHE_POLICY_H_
-#include "net/base/completion_callback.h"
-
class GURL;
namespace appcache {
@@ -18,16 +16,12 @@ class AppCachePolicy {
// Called prior to loading a main resource from the appache.
// Returns true if allowed. This is expected to return immediately
// without any user prompt.
- virtual bool CanLoadAppCache(const GURL& manifest_url) = 0;
-
- // Called prior to creating a new appcache.
- // Returns net::OK if allowed, net::ERR_ACCESS_DENIED if not allowed.
- // May also return net::ERR_IO_PENDING to indicate
- // that the completion callback will be notified (asynchronously and on
- // the current thread) of the final result. Note: The completion callback
- // must remain valid until notified.
- virtual int CanCreateAppCache(const GURL& manifest_url,
- net::CompletionCallback* callback) = 0;
+ virtual bool CanLoadAppCache(const GURL& manifest_url,
+ const GURL& first_party) = 0;
+
+ // Called prior to creating a new appcache. Returns true if allowed.
+ virtual bool CanCreateAppCache(const GURL& manifest_url,
+ const GURL& first_party) = 0;
protected:
~AppCachePolicy() {}
« no previous file with comments | « webkit/appcache/appcache_host_unittest.cc ('k') | webkit/appcache/appcache_request_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698