Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1210)

Unified Diff: content/browser/appcache/chrome_appcache_service.cc

Issue 7720022: Third-party appcache blocking. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Keeping up to date with trunk. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/appcache/chrome_appcache_service.h ('k') | content/browser/content_browser_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/appcache/chrome_appcache_service.cc
diff --git a/content/browser/appcache/chrome_appcache_service.cc b/content/browser/appcache/chrome_appcache_service.cc
index dc9b7934b7be8ab92d65ef66398d0768a69241b7..41936ef8f7605b45903af82d955b037f1a4a32a6 100644
--- a/content/browser/appcache/chrome_appcache_service.cc
+++ b/content/browser/appcache/chrome_appcache_service.cc
@@ -49,18 +49,19 @@ void ChromeAppCacheService::InitializeOnIOThread(
ChromeAppCacheService::~ChromeAppCacheService() {
}
-bool ChromeAppCacheService::CanLoadAppCache(const GURL& manifest_url) {
+bool ChromeAppCacheService::CanLoadAppCache(const GURL& manifest_url,
+ const GURL& first_party) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
// We don't prompt for read access.
return content::GetContentClient()->browser()->AllowAppCache(
- manifest_url, *resource_context_);
+ manifest_url, first_party, *resource_context_);
}
-int ChromeAppCacheService::CanCreateAppCache(
- const GURL& manifest_url, net::CompletionCallback* callback) {
+bool ChromeAppCacheService::CanCreateAppCache(
+ const GURL& manifest_url, const GURL& first_party) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
return content::GetContentClient()->browser()->AllowAppCache(
- manifest_url, *resource_context_) ? net::OK : net::ERR_ACCESS_DENIED;
+ manifest_url, first_party, *resource_context_);
}
void ChromeAppCacheService::Observe(int type,
« no previous file with comments | « content/browser/appcache/chrome_appcache_service.h ('k') | content/browser/content_browser_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698