Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 7720020: Get views_unittests pass on touch build (Closed)

Created:
9 years, 4 months ago by oshima
Modified:
9 years, 4 months ago
CC:
chromium-reviews, dhollowa, Paweł Hajdan Jr.
Visibility:
Public.

Description

Get views_unittests pass on touch build * Changed views test to use ViewsTestBase. * Always calls ViewsTestBase::SetUp/TearDown. Added flags to check if this is enforced. * Excluded tests that does not make sense on touch/pure views build. BUG=none TEST=views_unittets now passes on touch build, with a few exceptions below. WidgetTest.GrabUngrab: assigned to sadrul NativeTextfieldViewsTest.DragAndDrop_XXX: msw will look into it. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98128

Patch Set 1 #

Patch Set 2 : " #

Patch Set 3 : " #

Patch Set 4 : enable TouchSelectionControllerImplTest as they're fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -54 lines) Patch
M base/message_pump_x.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M views/controls/textfield/native_textfield_views_unittest.cc View 3 chunks +4 lines, -1 line 0 comments Download
M views/focus/focus_manager_unittest.cc View 10 chunks +11 lines, -17 lines 0 comments Download
M views/test/views_test_base.h View 2 chunks +13 lines, -3 lines 0 comments Download
M views/test/views_test_base.cc View 1 2 chunks +17 lines, -1 line 0 comments Download
M views/touchui/touch_selection_controller_impl_unittest.cc View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M views/view_unittest.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M views/views.gyp View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M views/widget/widget_unittest.cc View 1 2 8 chunks +22 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
oshima
9 years, 4 months ago (2011-08-24 20:42:15 UTC) #1
sadrul
LGTM. Thanks for doing this! All the touchui try/buildbots should be running views-unittests (I keep ...
9 years, 4 months ago (2011-08-24 20:50:22 UTC) #2
oshima
+evan for base/message_pump_x.cc change.
9 years, 4 months ago (2011-08-24 20:59:21 UTC) #3
oshima
varunjain fixed TouchSelectionControllerImplTest, and they're enabled now.
9 years, 4 months ago (2011-08-24 21:17:44 UTC) #4
Ben Goodger (Google)
LGTM
9 years, 4 months ago (2011-08-24 21:21:51 UTC) #5
Evan Martin
9 years, 4 months ago (2011-08-24 21:27:58 UTC) #6
base LGTM

Powered by Google App Engine
This is Rietveld 408576698