Issue 7720016: linux: clean up include paths for local nss headers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7720016: linux: clean up include paths for local nss headers (Closed)

Created:
9 years, 4 months ago by Evan Martin

Modified:
9 years, 4 months ago

Reviewers:
tony, agl

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

linux: clean up include paths for local nss headers The comment stated that gyp include paths come after cflags, but that is not true: include paths come before cflags. Use the gyp prepend operator just to be extra sure. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98071

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -9 lines)			Patch
	M	build/linux/system.gyp	View		1 chunk	+5 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

agl

LGTM. Before landing please drop a #error in net/third_party/nss/ssl/ssl.h and check that something hits it.

9 years, 4 months ago (2011-08-24 14:12:00 UTC) #2

Evan Martin

9 years, 4 months ago (2011-08-24 18:15:03 UTC) #3

I ran into this because I was accidentally screwing up this include
path in ninja and it was failing due to missing symbols (but not a
missing header) from finding the system header.

I did the #error check just to be sure.

On Wed, Aug 24, 2011 at 7:12 AM,  <agl@chromium.org> wrote:
> LGTM. Before landing please drop a #error in net/third_party/nss/ssl/ssl.h
> and
> check that something hits it.
>
> http://codereview.chromium.org/7720016/
>

Expand Messages | Collapse Messages