Print Preview: Fix printing from print preview.

chrome/renderer/print_web_view_helper.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/print_web_view_helper.h"
 
 #if defined(OS_MACOSX) && !defined(USE_SKIA)
 #include <CoreGraphics/CGContext.h>
 #endif
 
@@ skipping 558 matching lines @@
     return;
   }
 
   WebFrame* pdf_frame = pdf_element.document().frame();
   scoped_ptr<PrepareFrameAndViewForPrint> prepare;
   if (!InitPrintSettingsAndPrepareFrame(pdf_frame, &pdf_element, &prepare)) {
     NOTREACHED() << "Failed to initialize print page settings";
     return;
   }
 
-  if (!UpdatePrintSettings(job_settings)) {
+  if (!UpdatePrintSettings(job_settings, false)) {
     DidFinishPrinting(FAIL_PRINT);
     return;
   }
 
   // Render Pages for printing.
   if (!RenderPagesForPrint(pdf_frame, &pdf_element, prepare.get()))
     DidFinishPrinting(FAIL_PRINT);
 }
 
 bool PrintWebViewHelper::GetPrintFrame(WebKit::WebFrame** frame) {
@@ skipping 37 matching lines @@
 void PrintWebViewHelper::OnPrintPreview(const DictionaryValue& settings) {
   DCHECK(is_preview_);
   print_preview_context_.OnPrintPreview();
 
   if (!InitPrintSettings(print_preview_context_.frame(),
                          print_preview_context_.node())) {
     NOTREACHED();
     return;
   }
 
-  if (!UpdatePrintSettings(settings)) {
+  if (!UpdatePrintSettings(settings, true)) {
     DidFinishPrinting(FAIL_PREVIEW);
     return;
   }
 
   if (!print_pages_params_->params.is_first_request &&
       old_print_pages_params_.get() &&
       PrintMsg_Print_Params_IsEqual(*old_print_pages_params_,
                                     *print_pages_params_)) {
     PrintHostMsg_DidPreviewDocument_Params preview_params;
     preview_params.reuse_existing_data = true;
@@ skipping 397 matching lines @@
   prepare->reset(new PrepareFrameAndViewForPrint(print_pages_params_->params,
                                                  frame, node));
   UpdatePrintableSizeInPrintParameters(frame, node, prepare->get(),
                                        &print_pages_params_->params);
   Send(new PrintHostMsg_DidGetDocumentCookie(
         routing_id(), print_pages_params_->params.document_cookie));
   return true;
 }
 
 bool PrintWebViewHelper::UpdatePrintSettings(
-    const DictionaryValue& job_settings) {
+    const DictionaryValue& job_settings, bool is_preview) {
   PrintMsg_PrintPages_Params settings;
 
   Send(new PrintHostMsg_UpdatePrintSettings(routing_id(),
        print_pages_params_->params.document_cookie, job_settings, &settings));
-
   if (settings.params.dpi < kMinDpi || !settings.params.document_cookie)
     return false;
 
-  // Send default page layout to browser process.
-  PageSizeMargins default_page_layout;
-  GetPageSizeAndMarginsInPoints(NULL, -1, settings.params,
-                                &default_page_layout);
-  if (!old_print_pages_params_.get() ||
-      !PageLayoutIsEqual(*old_print_pages_params_, settings)) {
-    Send(new PrintHostMsg_DidGetDefaultPageLayout(routing_id(),
-                                                  default_page_layout));
-  }
-  SetCustomMarginsIfSelected(job_settings, &settings);
+  if (is_preview) {
+    // Validate expected print preview settings.
+    if (!job_settings.GetString(printing::kPreviewUIAddr,
+                                &(settings.params.preview_ui_addr)) ||
+        !job_settings.GetInteger(printing::kPreviewRequestID,
+                                 &(settings.params.preview_request_id)) ||
+        !job_settings.GetBoolean(printing::kIsFirstRequest,
+                                 &(settings.params.is_first_request))) {
+      NOTREACHED();
+      return false;
+    }
 
-  if (!job_settings.GetString(printing::kPreviewUIAddr,
-                              &(settings.params.preview_ui_addr)) ||
-      !job_settings.GetInteger(printing::kPreviewRequestID,
-                               &(settings.params.preview_request_id)) ||
-      !job_settings.GetBoolean(printing::kIsFirstRequest,
-                               &(settings.params.is_first_request))) {
-    NOTREACHED();
-    return false;
+    // Margins: Send default page layout to browser process.
+    PageSizeMargins default_page_layout;
+    GetPageSizeAndMarginsInPoints(NULL, -1, settings.params,
+                                  &default_page_layout);
+    if (!old_print_pages_params_.get() ||
+        !PageLayoutIsEqual(*old_print_pages_params_, settings)) {
+      Send(new PrintHostMsg_DidGetDefaultPageLayout(routing_id(),
+                                                    default_page_layout));
+    }
+    SetCustomMarginsIfSelected(job_settings, &settings);
+
+    // Header/Footer: Set |header_footer_info_|.
+    if (settings.params.display_header_footer) {
+      header_footer_info_.reset(new DictionaryValue());
+      header_footer_info_->SetString(printing::kSettingHeaderFooterDate,
+                                     settings.params.date);
+      header_footer_info_->SetString(printing::kSettingHeaderFooterURL,
+                                     settings.params.url);
+      header_footer_info_->SetString(printing::kSettingHeaderFooterTitle,
+                                     settings.params.title);
+    }
   }
 
   print_pages_params_.reset(new PrintMsg_PrintPages_Params(settings));
-
-  if (print_pages_params_->params.display_header_footer) {
-    header_footer_info_.reset(new DictionaryValue());
-    header_footer_info_->SetString(printing::kSettingHeaderFooterDate,
-                                   print_pages_params_->params.date);
-    header_footer_info_->SetString(printing::kSettingHeaderFooterURL,
-                                   print_pages_params_->params.url);
-    header_footer_info_->SetString(printing::kSettingHeaderFooterTitle,
-                                   print_pages_params_->params.title);
-  }
-
   Send(new PrintHostMsg_DidGetDocumentCookie(routing_id(),
                                              settings.params.document_cookie));
   return true;
 }
 
 bool PrintWebViewHelper::GetPrintSettingsFromUser(WebKit::WebFrame* frame,
                                                   int expected_pages_count,
                                                   bool use_browser_overlays) {
   PrintHostMsg_ScriptedPrint_Params params;
   PrintMsg_PrintPages_Params print_settings;
@@ skipping 328 matching lines @@
 const gfx::Size&
 PrintWebViewHelper::PrintPreviewContext::GetPrintCanvasSize() const {
   return prep_frame_view_->GetPrintCanvasSize();
 }
 
 void PrintWebViewHelper::PrintPreviewContext::ClearContext() {
   prep_frame_view_.reset();
   metafile_.reset();
   pages_to_render_.clear();
 }