Chromium Code Reviews

Unified Diff: webkit/plugins/ppapi/ppapi_plugin_instance.h

Issue 7719014: PrintPreview: Printing preview of a PDF on Mac with Skia only previews the last page of the PDF (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: webkit/plugins/ppapi/ppapi_plugin_instance.h
diff --git a/webkit/plugins/ppapi/ppapi_plugin_instance.h b/webkit/plugins/ppapi/ppapi_plugin_instance.h
index 346e157f9b863ed9825f680e410e3404fa853558..9eef2228656d8b4e0153e5b85c9d28da99b156ef 100644
--- a/webkit/plugins/ppapi/ppapi_plugin_instance.h
+++ b/webkit/plugins/ppapi/ppapi_plugin_instance.h
@@ -434,14 +434,14 @@ class PluginInstance : public base::RefCounted<PluginInstance>,
// variable to hold on to the pixels.
scoped_refptr<PPB_ImageData_Impl> last_printed_page_;
#endif // defined(OS_MACOSX)
-#if defined(OS_LINUX) || defined(OS_WIN)
- // When printing to PDF (print preview, Linux) the entire document goes into
- // one metafile. However, when users print only a subset of all the pages,
- // it is impossible to know if a call to PrintPage() is the last call.
- // Thus in PrintPage(), just store the page number in |ranges_|.
- // The hack is in PrintEnd(), where a valid |canvas_| is preserved in
- // PrintWebViewHelper::PrintPages. This makes it possible to generate the
- // entire PDF given the variables below:
+#if defined(USE_SKIA)
+ // Always when printing to PDF on Linux and when printing for preview on Mac
+ // and Win, the entire document goes into one metafile. However, when users
+ // print only a subset of all the pages, it is impossible to know if a call
+ // to PrintPage() is the last call. Thus in PrintPage(), just store the page
+ // number in |ranges_|. The hack is in PrintEnd(), where a valid |canvas_|
+ // is preserved in PrintWebViewHelper::PrintPages. This makes it possible
+ // to generate the entire PDF given the variables below:
//
// The most recently used WebCanvas, guaranteed to be valid.
SkRefPtr<WebKit::WebCanvas> canvas_;

Powered by Google App Engine