webkit/plugins/ppapi/ppapi_plugin_instance.h - Issue 7719014: PrintPreview: Printing preview of a PDF on Mac with Skia only previews the last page of the PDF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/ppapi/ppapi_plugin_instance.h

Issue 7719014: PrintPreview: Printing preview of a PDF on Mac with Skia only previews the last page of the PDF (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: '' Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« printing/metafile_skia_wrapper.h ('K') | « printing/metafile_skia_wrapper.cc ('k') | webkit/plugins/ppapi/ppapi_plugin_instance.cc » ('j') | webkit/plugins/ppapi/ppapi_plugin_instance.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webkit/plugins/ppapi/ppapi_plugin_instance.h

diff --git a/webkit/plugins/ppapi/ppapi_plugin_instance.h b/webkit/plugins/ppapi/ppapi_plugin_instance.h

index 346e157f9b863ed9825f680e410e3404fa853558..a09573aaa6af189f4d32fa37d77840f220f9c52a 100644

--- a/webkit/plugins/ppapi/ppapi_plugin_instance.h

+++ b/webkit/plugins/ppapi/ppapi_plugin_instance.h

@@ -434,7 +434,7 @@ class PluginInstance : public base::RefCounted<PluginInstance>,

// variable to hold on to the pixels.

scoped_refptr<PPB_ImageData_Impl> last_printed_page_;

#endif // defined(OS_MACOSX)

-#if defined(OS_LINUX) || defined(OS_WIN)

+#if defined(USE_SKIA)

// When printing to PDF (print preview, Linux) the entire document goes into

// one metafile. However, when users print only a subset of all the pages,

// it is impossible to know if a call to PrintPage() is the last call.