Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3627)

Unified Diff: chrome/browser/sync/syncable/directory_backing_store_unittest.cc

Issue 7719007: Add a gyp flag to enable dcheck by default in release without (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/syncable/directory_backing_store_unittest.cc
===================================================================
--- chrome/browser/sync/syncable/directory_backing_store_unittest.cc (revision 98477)
+++ chrome/browser/sync/syncable/directory_backing_store_unittest.cc (working copy)
@@ -1667,8 +1667,10 @@
// In release mode, we expect the sync database to nuke itself and start
// over if it detects invalid/corrupted data.
-#if defined(NDEBUG)
+#if defined(NDEBUG) && !defined(DCHECK_ALWAYS_ON)
EXPECT_TRUE(dbs->BeginLoad());
+#elif defined(NDEBUG) && defined(DCHECK_ALWAYS_ON)
+ EXPECT_DEATH(dbs->BeginLoad(), "stmt_");
#else
EXPECT_DEATH(dbs->BeginLoad(), "sqlite error");
#endif

Powered by Google App Engine
This is Rietveld 408576698