Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4712)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/browser_main_unittest.cc

Issue 7719007: Add a gyp flag to enable dcheck by default in release without (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/logging.h ('K') | « build/common.gypi ('k') | chrome/browser/prefs/incognito_mode_prefs_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_main_unittest.cc
===================================================================
--- chrome/browser/browser_main_unittest.cc (revision 98477)
+++ chrome/browser/browser_main_unittest.cc (working copy)
@@ -63,6 +63,11 @@
scoped_ptr<BrowserMainParts> bw(BrowserMainParts::CreateBrowserMainParts(
*params));
+#if defined(NDEBUG) && defined(DCHECK_ALWAYS_ON)
+ EXPECT_DEATH(bw->WarmConnectionFieldTrial(),
+ "Not a valid socket reuse policy group");
+#else
EXPECT_DEBUG_DEATH(bw->WarmConnectionFieldTrial(),
"Not a valid socket reuse policy group");
+#endif
}
« base/logging.h ('K') | « build/common.gypi ('k') | chrome/browser/prefs/incognito_mode_prefs_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698