Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/base/text/bytes_formatting_unittest.cc

Issue 7719007: Add a gyp flag to enable dcheck by default in release without (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_protocol_test.cc ('k') | ui/gfx/rect_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/text/bytes_formatting_unittest.cc
===================================================================
--- ui/base/text/bytes_formatting_unittest.cc (revision 101967)
+++ ui/base/text/bytes_formatting_unittest.cc (working copy)
@@ -20,7 +20,7 @@
{10LL*1024*1024*1024, DATA_UNITS_GIBIBYTE},
{10LL*1024*1024*1024*1024, DATA_UNITS_TEBIBYTE},
{~(1LL<<63), DATA_UNITS_PEBIBYTE},
-#ifdef NDEBUG
+#if defined(NDEBUG) && !defined(DCHECK_ALWAYS_ON)
{-1, DATA_UNITS_BYTE},
#endif
};
@@ -63,7 +63,7 @@
"1.9", "1.9 GB"},
{10LL*1024*1024*1024, DATA_UNITS_GIBIBYTE, "10.0", "10.0 GB"},
{100LL*1024*1024*1024, DATA_UNITS_GIBIBYTE, "100", "100 GB"},
-#ifdef NDEBUG
+#if defined(NDEBUG) && !defined(DCHECK_ALWAYS_ON)
{-1, DATA_UNITS_BYTE, "", ""},
#endif
};
« no previous file with comments | « net/spdy/spdy_protocol_test.cc ('k') | ui/gfx/rect_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698