Add external extensions json source in proper mac location.

base/file_util.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains utility functions for dealing with the local
 // filesystem.
 
 #ifndef BASE_FILE_UTIL_H_
 #define BASE_FILE_UTIL_H_
 #pragma once
@@ skipping 25 matching lines @@
 #include "base/file_descriptor_posix.h"
 #include "base/logging.h"
 #endif
 
 namespace base {
 class Time;
 }
 
 namespace file_util {
 
+
+
+
+
+
+
+

[Evan Martin, 2011/09/21 18:15:24]

Probably didn't mean for so much whitespace here and below.

[Sam Kerner (Chrome), 2011/09/21 18:57:07]

Trybots have been failing to patch changes to this file, so I have been playing
with whitespace and position of this code to appease them.  Removed.

+#if defined(OS_POSIX)
+// Test that |path| can only be changed by a specific user and group.
+// Specifically, test that all parts of |path| under and including |base|
+// exist, are owned by a specific user and group, are not writable by all
+// users, and are not symbolic links. This is useful for checking that a
+// config file is administrator-controlled. |base| must contain |path|.
+BASE_EXPORT bool VerifyPathControlledByUser(const FilePath& base,
+                                            const FilePath* path,

[Evan Martin, 2011/09/21 18:15:24]

Why is this a pointer?  If it being NULL has a meaning, please document that in
the main comment.  ...but it looks like the .cc file has a different prototype,
so maybe this function isn't used (?)

[Sam Kerner (Chrome), 2011/09/21 18:57:07]

Fixed.

+                                            uid_t owner_uid,
+                                            gid_t group_gid);
+#endif  // defined(OS_POSIX)
+
+#if defined(OS_MACOSX)
+// Is |path|writable only by a user with administrator privlages?
+// This function uses Mac OS conventions. It assumes that the superuser
+// has uid 0, and the administrator group is named "admin". Test that
+// |path| and every parent directory (including the root of the
+// filesystem) are owned by the superuser, controlled by the admin
+// group, are not writable by all users, and contain no symbolic links.
+// Will return false if |path| does not exist.
+BASE_EXPORT bool VerifyPathControlledByAdmin(const FilePath& path);
+#endif  // defined(OS_MACOSX)
+
+
+
+
+
+
 //-----------------------------------------------------------------------------
 // Functions that operate purely on a path string w/o touching the filesystem:

[Evan Martin, 2011/09/21 18:15:24]

It looks like this file might be organized into categories.  I wonder if you
could find a more appropriate place for your addition than at the top.

[Sam Kerner (Chrome), 2011/09/21 18:57:07]

Put them with functions that touch the filesystem.  Put them above classes,
which are all at the end of the file.

 
 // Returns true if the given path ends with a path separator character.
 BASE_EXPORT bool EndsWithSeparator(const FilePath& path);
 
 // Makes sure that |path| ends with a separator IFF path is a directory that
 // exists. Returns true if |path| is an existing directory, false otherwise.
 BASE_EXPORT bool EnsureEndsWithSeparator(FilePath* path);
 
 // Convert provided relative path into an absolute path.  Returns false on
 // error. On POSIX, this function fails if the path does not exist.
@@ skipping 540 matching lines @@
 BASE_EXPORT bool GetFileSystemType(const FilePath& path, FileSystemType* type);
 #endif
 
 }  // namespace file_util
 
 // Deprecated functions have been moved to this separate header file,
 // which must be included last after all the above definitions.
 #include "base/file_util_deprecated.h"
 
 #endif  // BASE_FILE_UTIL_H_