Issue 7718008: Use a split toggle button to reflect scaling state.

Issue 7718008: Use a split toggle button to reflect scaling state. (Closed)

Created:
9 years, 4 months ago by Jamie

Modified:
9 years, 4 months ago

Reviewers:
garykac

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Use a split toggle button to reflect scaling state. BUG=None TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98366

Patch Set 1 #

Patch Set 2 : Use an image instead of a split button. #

Patch Set 3 : Added missing newline. #

Patch Set 4 : Added tool-tip for scale-to-fit button. #

Total comments: 1

Patch Set 5 : Fixed i18n-content tag. #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -26 lines)			Patch
M	remoting/remoting.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	remoting/webapp/me2mom/_locales/en/messages.json	View	1 2 3 4	2 chunks	+4 lines, -4 lines	0 comments	Download
M	remoting/webapp/me2mom/choice.css	View	1	2 chunks	+6 lines, -14 lines	0 comments	Download
M	remoting/webapp/me2mom/choice.html	View	1 2 3 4	1 chunk	+4 lines, -2 lines	0 comments	Download
M	remoting/webapp/me2mom/client_session.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/webapp/me2mom/remoting.js	View	1 2 3 4	4 chunks	+17 lines, -6 lines	0 comments	Download
A	remoting/webapp/me2mom/scale-to-fit.png	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jamie

This changes the scale-to-fit UI to be a split-button toggle, as per Ken's mocks, rather ...

9 years, 4 months ago (2011-08-23 21:35:58 UTC) #1

Jamie

Here's the new look, using an image instead of a split button.

9 years, 4 months ago (2011-08-25 20:01:15 UTC) #2

Jamie

Sorry, one last refinement: we want a tool-tip for the button describing what it does.

9 years, 4 months ago (2011-08-25 20:33:02 UTC) #4

garykac

9 years, 4 months ago (2011-08-26 00:43:17 UTC) #5

LGTM after typo is fixed

http://codereview.chromium.org/7718008/diff/6002/remoting/webapp/me2mom/remot...
File remoting/webapp/me2mom/remoting.js (right):

http://codereview.chromium.org/7718008/diff/6002/remoting/webapp/me2mom/remot...
remoting/webapp/me2mom/remoting.js:150: button.title =
chrome.i18n.getMessage(/*i18-content*/'TOOLTIP_SCALING');
/*i18n-content*/

Expand Messages | Collapse Messages