Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 7718004: ppapi: Make 0.4 the default for PPP_Printing_Dev, leave backwards-compat (Closed)

Created:
9 years, 4 months ago by dmichael (off chromium)
Modified:
9 years, 3 months ago
Reviewers:
Lei Zhang, brettw
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, jam, elijahtaylor (use chromium), vandebo (ex-Chrome), polina
Visibility:
Public.

Description

ppapi: Make 0.4 the default for PPP_Printing_Dev, leave backwards-compat. Since I didn't land this before the NaCl proxy move to chrome, I had to incorporate the proxy changes that were in http://codereview.chromium.org/7714041/ After PDF lands, I should be able to remove backwards-compat code. BUG=80696 TEST=ppapi tests, manual test of PDF plugin Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98684

Patch Set 1 #

Patch Set 2 : Put back ABI backwards-compat. #

Patch Set 3 : Incorporate NaCl proxy changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -121 lines) Patch
M ppapi/c/dev/ppp_printing_dev.h View 1 4 chunks +3 lines, -41 lines 0 comments Download
M ppapi/cpp/dev/printing_dev.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ppapi/cpp/dev/printing_dev.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_printing.cc View 1 2 1 chunk +7 lines, -22 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_ppp_printing_rpc_server.cc View 1 2 2 chunks +5 lines, -21 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppp_printing.srpc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppp_rpc_client.cc View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppp_rpc_server.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/trusted/srpcgen/ppp_rpc.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/untrusted/srpcgen/ppp_rpc.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.cc View 1 2 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dmichael (off chromium)
9 years, 4 months ago (2011-08-23 21:12:09 UTC) #1
Lei Zhang
For the PDF plugin, we can either just define PPP_PRINTING_DEV_USE_0_4, or remove the 0_3 printing ...
9 years, 4 months ago (2011-08-23 21:47:54 UTC) #2
brettw
LGTM
9 years, 4 months ago (2011-08-23 23:42:33 UTC) #3
dmichael (off chromium)
thestig@ and other PDF team members: I'm ready to land this whenever you're ready for ...
9 years, 4 months ago (2011-08-24 17:45:13 UTC) #4
Lei Zhang
I have a CL ready to go, just waiting for a review. On 2011/08/24 17:45:13, ...
9 years, 4 months ago (2011-08-24 20:32:20 UTC) #5
Lei Zhang
PDF side is ready. Shall we commit this?
9 years, 4 months ago (2011-08-26 18:20:56 UTC) #6
dmichael(do not use this one)
I'm ooo. Let's plan on Monday if that's okay. On Aug 26, 2011 12:20 PM, ...
9 years, 4 months ago (2011-08-26 18:30:56 UTC) #7
dmichael (off chromium)
Just FYI... the NaCl proxy moved, so I had to put the NaCl proxy change ...
9 years, 3 months ago (2011-08-29 19:17:02 UTC) #8
dmichael (off chromium)
9 years, 3 months ago (2011-08-29 19:23:13 UTC) #9
Oh, and for the curious, here's the NaCl CL from which I copied:
http://codereview.chromium.org/7714041/
(The code is the same other than a small bug in my code there which is fixed
here)

Powered by Google App Engine
This is Rietveld 408576698