ppapi: Make 0.4 the default for PPP_Printing_Dev, leave backwards-compat.
Since I didn't land this before the NaCl proxy move to chrome, I had to incorporate the proxy changes that were in http://codereview.chromium.org/7714041/
After PDF lands, I should be able to remove backwards-compat code.
BUG=80696
TEST=ppapi tests, manual test of PDF plugin
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98684
9 years, 4 months ago
(2011-08-23 21:12:09 UTC)
#1
Lei Zhang
For the PDF plugin, we can either just define PPP_PRINTING_DEV_USE_0_4, or remove the 0_3 printing ...
9 years, 4 months ago
(2011-08-23 21:47:54 UTC)
#2
For the PDF plugin, we can either just define PPP_PRINTING_DEV_USE_0_4, or
remove the 0_3 printing dev code altogether. Either way it should be trivial and
I can do it whenever you are ready.
brettw
LGTM
9 years, 4 months ago
(2011-08-23 23:42:33 UTC)
#3
LGTM
dmichael (off chromium)
thestig@ and other PDF team members: I'm ready to land this whenever you're ready for ...
9 years, 4 months ago
(2011-08-24 17:45:13 UTC)
#4
thestig@ and other PDF team members: I'm ready to land this whenever you're
ready for it.
Alternately, if you'd rather take this patch and add your PDF changes to land it
one CL, I'd be fine with that too.
Lei Zhang
I have a CL ready to go, just waiting for a review. On 2011/08/24 17:45:13, ...
9 years, 4 months ago
(2011-08-24 20:32:20 UTC)
#5
I have a CL ready to go, just waiting for a review.
On 2011/08/24 17:45:13, dmichael wrote:
> thestig@ and other PDF team members: I'm ready to land this whenever you're
> ready for it.
>
> Alternately, if you'd rather take this patch and add your PDF changes to land
it
> one CL, I'd be fine with that too.
Lei Zhang
PDF side is ready. Shall we commit this?
9 years, 4 months ago
(2011-08-26 18:20:56 UTC)
#6
PDF side is ready. Shall we commit this?
dmichael(do not use this one)
I'm ooo. Let's plan on Monday if that's okay. On Aug 26, 2011 12:20 PM, ...
9 years, 4 months ago
(2011-08-26 18:30:56 UTC)
#7
Just FYI... the NaCl proxy moved, so I had to put the NaCl proxy change ...
9 years, 3 months ago
(2011-08-29 19:17:02 UTC)
#8
Just FYI... the NaCl proxy moved, so I had to put the NaCl proxy change in to
this CL. That was already LGTMed in a separate CL (with a couple of caveats are
no longer applicable or were ironed out). So I don't think I need an additional
review, but if anybody wants to look, feel free. I intend to check in once my
trybots look good.
dmichael (off chromium)
Oh, and for the curious, here's the NaCl CL from which I copied: http://codereview.chromium.org/7714041/ (The ...
9 years, 3 months ago
(2011-08-29 19:23:13 UTC)
#9
Oh, and for the curious, here's the NaCl CL from which I copied:
http://codereview.chromium.org/7714041/
(The code is the same other than a small bug in my code there which is fixed
here)
Issue 7718004: ppapi: Make 0.4 the default for PPP_Printing_Dev, leave backwards-compat
(Closed)
Created 9 years, 4 months ago by dmichael (off chromium)
Modified 9 years, 3 months ago
Reviewers: brettw, Lei Zhang
Base URL: svn://svn.chromium.org/chrome/trunk/src
Comments: 0