Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 7717028: views: Remove NativeTextButton::SetLabel() and replace all call sites with SetText(). (Closed)

Created:
9 years, 4 months ago by tfarina
Modified:
9 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, dhollowa
Visibility:
Public.

Description

views: Remove NativeTextButton::SetLabel() and replace all call sites with SetText(). Note: This was a TODO added by rogerta@chromium.org BUG=None TEST=None R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98259

Patch Set 1 #

Patch Set 2 : also removes label() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -18 lines) Patch
M chrome/browser/chromeos/login/eula_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/new_user_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/first_run_search_engine_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/button/checkbox.h View 1 chunk +0 lines, -4 lines 0 comments Download
M views/controls/button/text_button.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M views/controls/message_box_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/window/dialog_client_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
9 years, 4 months ago (2011-08-24 18:42:18 UTC) #1
sky
9 years, 4 months ago (2011-08-25 03:46:01 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698