Adding Size() to AbstractFileEnumerator

webkit/fileapi/file_system_file_util.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_FILEAPI_FILE_SYSTEM_FILE_UTIL_H_
 #define WEBKIT_FILEAPI_FILE_SYSTEM_FILE_UTIL_H_
 
+#include <vector>
+
 #include "base/callback.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/file_util_proxy.h"
 #include "base/memory/ref_counted.h"
 #include "base/platform_file.h"
 #include "base/tracked_objects.h"
 #include "webkit/fileapi/file_system_types.h"
 
 namespace base {
@@ skipping 197 matching lines @@
       const FilePath& file_path);
 
   // It will be implemented by each subclass such as FileSystemFileEnumerator.
   class AbstractFileEnumerator {
    public:
     virtual ~AbstractFileEnumerator() {}
 
     // Returns an empty string if there are no more results.
     virtual FilePath Next() = 0;
 
+    virtual int64 Size() = 0;
     virtual bool IsDirectory() = 0;
   };
 
   class EmptyFileEnumerator : public AbstractFileEnumerator {
-    virtual FilePath Next() { return FilePath(); }
-    virtual bool IsDirectory() { return false; }
+    virtual FilePath Next() OVERRIDE { return FilePath(); }
+    virtual int64 Size() OVERRIDE { return 0; }
+    virtual bool IsDirectory() OVERRIDE { return false; }
   };
 
   // Returns a pointer to a new instance of AbstractFileEnumerator which is
   // implemented for each FileUtil subclass. The instance needs to be freed
   // by the caller, and its lifetime should not extend past when the current
   // call returns to the main FILE message loop.
+  //
+  // The instance may depend on FileSystemOperationContext instance past as
+  // context. The context should be valid in the lifetime of the enumerator
+  // instance.

[ericu, 2011/08/26 16:38:24]

How about just "The supplied context must remain valid for at least the lifetime
of the enumerator instance." ?

[tzik, 2011/08/29 02:33:32]

Done.

   virtual AbstractFileEnumerator* CreateFileEnumerator(
-      FileSystemOperationContext* unused,
+      FileSystemOperationContext* context,
       const FilePath& root_path);
 
  protected:
   // Deletes a directory and all entries under the directory.
   //
   // This method is called from Delete.  It internally calls two following
   // virtual methods,
   // - (virtual) DeleteFile to delete files, and
   // - (virtual) DeleteSingleDirectory to delete empty directories after all
   // the files are deleted.
@@ skipping 28 matching lines @@
       const FilePath& src_file_path,
       const FilePath& dest_file_path,
       bool copy);
 
   DISALLOW_COPY_AND_ASSIGN(FileSystemFileUtil);
 };
 
 }  // namespace fileapi
 
 #endif  // WEBKIT_FILEAPI_FILE_SYSTEM_FILE_UTIL_H_