Adding Size() to AbstractFileEnumerator

webkit/fileapi/local_file_system_file_util.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/fileapi/local_file_system_file_util.h"
 
 #include "base/file_util_proxy.h"
 #include "googleurl/src/gurl.h"
 #include "webkit/fileapi/file_system_context.h"
 #include "webkit/fileapi/file_system_operation_context.h"
@@ skipping 223 matching lines @@
                                 const FilePath& virtual_root_path,
                                 bool recursive,
                                 file_util::FileEnumerator::FileType file_type)
       : file_enum_(platform_root_path, recursive, file_type),
         platform_root_path_(platform_root_path),
         virtual_root_path_(virtual_root_path) {
   }
 
   ~LocalFileSystemFileEnumerator() {}
 
-  virtual FilePath Next();
-  virtual bool IsDirectory();
+  virtual FilePath Next() OVERRIDE;
+  virtual int64 Size() OVERRIDE;
+  virtual bool IsDirectory() OVERRIDE;
 
  private:
   file_util::FileEnumerator file_enum_;
   FilePath platform_root_path_;
   FilePath virtual_root_path_;
 };
 
 FilePath LocalFileSystemFileEnumerator::Next() {
   FilePath next = file_enum_.Next();
   if (next.empty())
     return next;
 
   FilePath path;
   platform_root_path_.AppendRelativePath(next, &path);
   return virtual_root_path_.Append(path);
 }
 
+int64 LocalFileSystemFileEnumerator::Size() {
+  file_util::FileEnumerator::FindInfo file_util_info;

[ericu, 2011/08/25 18:29:30]

Is there any reason that we shouldn't cache the return from GetFindInfo as you
do in FileSystemFileUtil?

[tzik, 2011/08/26 02:41:53]

Done.  No reason other than making the patch smaller.

+  file_enum_.GetFindInfo(&file_util_info);
+  return file_util::FileEnumerator::GetFilesize(file_util_info);
+}
+
 bool LocalFileSystemFileEnumerator::IsDirectory() {
   file_util::FileEnumerator::FindInfo file_util_info;
   file_enum_.GetFindInfo(&file_util_info);
   return file_util::FileEnumerator::IsDirectory(file_util_info);
 }
 
 FileSystemFileUtil::AbstractFileEnumerator*
 LocalFileSystemFileUtil::CreateFileEnumerator(
     FileSystemOperationContext* context,
     const FilePath& root_path) {
@@ skipping 16 matching lines @@
     const FilePath& virtual_path) {
   FilePath root = context->file_system_context()->path_manager()->
       ValidateFileSystemRootAndGetPathOnFileThread(origin_url, type,
           virtual_path, false);
   if (root.empty())
     return FilePath();
   return root.Append(virtual_path);
 }
 
 }  // namespace fileapi