Issue 7717019: Do not dereference potentially invalid frame pointer.

Issue 7717019: Do not dereference potentially invalid frame pointer. (Closed)

Created:
9 years, 4 months ago by Aaron Boodman

Modified:
9 years, 4 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Do not dereference potentially invalid frame pointer in extension event bindings. I think this might fix bugs 93768 and 93774. BUG=93768, 93774 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98390

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix crashes in a few browser tests #

Patch Set 3 : HATE #

Patch Set 4 : cleanup the hate #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -22 lines)			Patch
M	chrome/renderer/extensions/bindings_utils.h	View	1 2 3	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/renderer/extensions/bindings_utils.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/extensions/event_bindings.cc	View	1 2 3	3 chunks	+16 lines, -17 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

http://codereview.chromium.org/7717019/diff/1/chrome/renderer/extensions/event_bindings.cc File chrome/renderer/extensions/event_bindings.cc (right): http://codereview.chromium.org/7717019/diff/1/chrome/renderer/extensions/event_bindings.cc#newcode359 chrome/renderer/extensions/event_bindings.cc:359: NOTREACHED(); According to the code upstream, this should not ...

9 years, 4 months ago (2011-08-24 02:58:16 UTC) #1

Aaron Boodman

I had to do this a different way because sometimes a frame can not have ...

9 years, 4 months ago (2011-08-25 21:22:46 UTC) #3

lgtm

Expand Messages | Collapse Messages